Skip to content

[dotnet] [bidi] Add Emulation.SetTextLayoutModeOverride command - #18043

Merged
nvborisenko merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:bidi-emulation-settextlayout
Sep 16, 2026
Merged

nvborisenko merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:bidi-emulation-settextlayout

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

https://w3c.github.io/webdriver-bidi/#command-emulation-setTextLayoutModeOverride

💥 What does this PR do?

This pull request adds support for overriding the text layout mode in the BiDi Emulation module, allowing clients to set or reset the text layout mode (such as "mobile") for one or more browsing contexts. The implementation includes new API methods, parameter/result types, and corresponding tests.

New Feature: Text Layout Mode Override

  • Added a new API method SetTextLayoutModeOverrideAsync to the IEmulationModule interface and its implementation in EmulationModule.cs, enabling clients to set the text layout mode override. [1] [2]
  • Introduced new types in SetTextLayoutModeOverride.cs for parameters, options, result, and the TextLayoutMode enum.
  • Registered the new parameter and result types for JSON serialization in EmulationModule.cs.

Testing

  • Added two new tests in EmulationTests.cs to verify setting and resetting the text layout mode override.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • New feature (non-breaking change which adds functionality and tests!)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label Sep 16, 2026
@nvborisenko
nvborisenko merged commit 718adc8 into SeleniumHQ:trunk Sep 16, 2026
24 checks passed
@nvborisenko
nvborisenko deleted the bidi-emulation-settextlayout branch September 16, 2026 19:46
This was referenced Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants