[dotnet] [build] Include package license/notice files - #18048
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Thank you, @nvborisenko for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
|
/agentic_review |
1 similar comment
|
/agentic_review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
|
I think .NET should follow the existing convention with the //:license filegroup instead of creating something new. |
|
Done, please take a look. |
🔗 Related Issues
Contributes to #16113
💥 What does this PR do?
This pull request ensures that the
LICENSEandNOTICEfiles are included in the distributed artifacts for both the Selenium.Support and Selenium.WebDriver .NET packages, as well as making these files available as exported files in the Bazel build. This change helps maintain compliance with open source licensing requirements.Packaging and distribution compliance:
dotnet/src/support/BUILD.bazelanddotnet/src/webdriver/BUILD.bazelto includeLICENSEandNOTICEfiles in the NuGet package contents for both Selenium.Support and Selenium.WebDriver. [1] [2]dotnet/src/support/Selenium.Support.nuspecanddotnet/src/webdriver/Selenium.WebDriver.nuspecto explicitly addLICENSEandNOTICEfiles to the NuGet packages. [1] [2]Build system updates:
LICENSEandNOTICEto the list of exported files inBUILD.bazelso they are available for packaging and distribution.🤖 AI assistance
🔄 Types of changes