You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[dotnet] [test] Upgrade NUnit library to v5 - #18114
This pull request updates the NUnit dependencies to their latest versions in both the paket.dependencies and paket.nuget.bzl files. The main focus is on keeping the test framework and analyzers current, which may bring new features, bug fixes, and improved compatibility.
Dependency updates:
Upgraded the NUnit package from version 4.6.0 to 5.0.0 in both dotnet/paket.dependencies and dotnet/paket.nuget.bzl. [1][2]
Upgraded the NUnit.Analyzers package from version 4.13.0 to 4.15.0 in both dotnet/paket.dependencies and dotnet/paket.nuget.bzl. [1][2]
🤖 AI assistance
No substantial AI assistance used
AI assisted (complete below)
Tool(s):
What was generated:
I reviewed all AI output and can explain the change
The support packages contain example code that many users find helpful, but they do not necessarily represent
the best practices for using Selenium, and the Selenium team is not currently merging changes to them.
After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium
to work, we will likely close the PR.
We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
If you have any questions, please contact us
• Upgrade NUnit and its analyzers across .NET test projects and Bazel dependencies.
• Refresh resolved dependencies, including transitive packages required by NUnit 5.
• Await the BiDi cancellation assertion to match NUnit 5's async API.
Keep the Paket lockfile, generated Bazel package metadata, and project references synchronized as this PR does. Centralizing versions in MSBuild alone would not replace Bazel's separate dependency metadata; review should focus on NUnit 5 compatibility and test results.
Files changed (8) +29 / -29
Tests (1) +1 / -1
SessionTests.csAwait the cancellation exception assertion+1/-1
Await the cancellation exception assertion
• Awaits Assert.ThrowsAsync in the event-stream cancellation test to accommodate NUnit 5's asynchronous assertion API.
paket.lockLock upgraded NUnit and transitive packages+13/-13
Lock upgraded NUnit and transitive packages
• Records the new NUnit and analyzer versions. Also raises System.Threading.Tasks.Extensions, System.ValueTuple, and System.Runtime.CompilerServices.Unsafe and refreshes several framework-specific dependency restrictions.
• Updates package versions and SHA-512 hashes for NUnit, its analyzers, and the upgraded transitive packages. Refreshes framework-specific dependency metadata for System.Threading.Tasks.Extensions and System.ValueTuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-buildIncludes scripting, bazel and CI integrationsB-supportIssue or PR related to support classesC-dotnet.NET Bindings
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NUnit 5 is released.
💥 What does this PR do?
This pull request updates the NUnit dependencies to their latest versions in both the
paket.dependenciesandpaket.nuget.bzlfiles. The main focus is on keeping the test framework and analyzers current, which may bring new features, bug fixes, and improved compatibility.Dependency updates:
NUnitpackage from version 4.6.0 to 5.0.0 in bothdotnet/paket.dependenciesanddotnet/paket.nuget.bzl. [1] [2]NUnit.Analyzerspackage from version 4.13.0 to 4.15.0 in bothdotnet/paket.dependenciesanddotnet/paket.nuget.bzl. [1] [2]🤖 AI assistance
🔄 Types of changes