Repository navigation
[js] Add webextension methods on the driver with BiDi and fallback - #18127
Conversation
…into js-webextension
…into js-webextension
PR Summary by QodoAdd JavaScript WebExtension driver APIs with Firefox fallback
AI Description
Diagram
High-Level Assessment
Files changed (13)
|
Code Review by Qodo
1. Remote installs report the wrong cause
|
|
Code review by qodo was updated up to the latest commit 912bfb5 |
…does not support it
|
Code review by qodo was updated up to the latest commit ae50dc1 |
|
oops, I broke this trying to fix the test fixture on trunk. I'll merge the fix, once tests pass, should be good to merge. |
|
Code review by qodo was updated up to the latest commit bc4c912 |
|
Just for me to understand (pseudo code): Is it the best effort? Like if "bidi enabled" - try, hm something bad - fallback. Runtime decision? |
|
I am asking because soon I should introduce in .NET to factory BiDi connection. This connection wants to be lazy (seems). |
|
@nvborisenko see the decisions here: https://github.com/seleniumhq/selenium/blob/trunk/docs/decisions/17817-driver-extension-install.md#decision No fallback/retry, it's toggled on the websocketurl capability, so using the method in a classic session with Chrome will give an error, and using it with Firefox will use the classic endpoint. |
🔗 Related Issues
Addresses ADR webextension. Related to #17933
💥 What does this PR do?
🔧 Implementation Notes
🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes