Repository navigation
docs: sync after #430 (clean demo URLs in the E2E catalogue) - #431
Merged
Merged
Conversation
Teil 85 still described the demo suite as it worked before #430: served from a sub-path with relative asset URLs, and an in-app documentation link pointing at `../docs/`. The demo now builds with `base: '/demo/'`, the test server mirrors the Apache page fallback so that page paths get the shell while missing assets stay 404, and the spec asserts the documentation link is `/docs/`. Also names `routing.spec.ts`, which #430 added to the same suite, and lists the four scenarios it covers: clean-path deep links with reload, legacy hash links being rewritten, browser history keeping the in-memory world, and the page fallback separating pages from assets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXy9XQTptzYNRB7yFMpVMC
2 tasks
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
#430 moved the browser demo from a sub-path deployment with relative asset URLs to clean paths under
/demo/. Teil 85 of the manual E2E catalogue still described the old arrangement, and one of its check points now states the opposite of what the spec asserts.Driven entirely by #430 — Use clean demo URLs and redirect old Pages links.
docs/testing/E2ETests.mdTeil 85, introbase: './'not rewriting URLs inside JavaScript stringsvite.demo.config.tssetsbase: '/demo/';e2e/demo-server.mjsserves/demo/and mirrors the Apache page fallback, so page paths get the shell and missing assets stay 404docs/testing/E2ETests.mdTeil 85, check point 1../docs/statt/docs/"e2e-demo/demo-smoke.spec.ts:186assertsexpect(docsHref).toBe('/docs/')— the catalogue stated the inversedocs/testing/E2ETests.mdTeil 85, automation line + points 9–12demo-smoke.spec.tsonlye2e-demo/routing.spec.tsto the same suite; its four scenarios (clean-path deep link with reload, legacy hash rewriting, browser history keeping the in-memory world, page fallback vs. asset 404) are now listeddocs/testing/E2ETests.mdfooterHow
Markdown only, one file. Teil count is unchanged at 85, so the "(85 Teile)" claim in
src/nodepilot-ui/e2e/README.mdstill holds and needed no edit.Surfaces checked and found already correct — #430 synced them itself:
README.md,CLAUDE.md(incl. the 240 Vitest / 77 E2E figures, re-derived here as 240 and 77),src/nodepilot-ui/CLAUDE.md,src/nodepilot-ui/e2e/README.md,CONTRIBUTING.md,RELEASING.md,deploy/README.md,src/nodepilot-docs-ui/README.md,CHANGELOG.mdandcontent/{de,en}/getting-started/live-demo.md. The remainingsev7enup.github.ioliterals are the redirect source origin in code and tests, not stale prose. The docsindex.htmlstill carries no inline<script>, so the CSP note inCLAUDE.mdis unaffected.Two findings were deliberately not applied here and are filed separately as #432: naming
e2e-demo/routing.spec.tsin theCLAUDE.mdguard-test table, and thesrc/nodepilot-docs-ui/e2e-site/suite (npm run test:site:e2e, three specs incl. the newpages-redirects.spec.ts) being undocumented in every markdown surface. Both are placement calls rather than mechanical corrections.Testing
No test code changed.
docs/testing/E2ETests.mdis not read by any guard test — nothing undertests/or the frontend suites parses it — so the claims above were verified by reading the code the catalogue describes:src/nodepilot-ui/vite.demo.config.ts(base: '/demo/')src/nodepilot-ui/e2e/demo-server.mjs(page fallback, asset misses 404)src/nodepilot-ui/playwright.demo.config.ts(baseURL…/demo/)src/nodepilot-ui/e2e-demo/demo-smoke.spec.tsande2e-demo/routing.spec.tsGuard/parity tests run for whatever this change touches — none apply; re-derived the two
DocumentationCountsTestsfrontend figures by hand (240 Vitest files, 77 specs undere2e/), both already correct onmainDocs updated
Checklist
main; no direct commits tomaincontent/{de,en}counterpart to mirror)Opened by the nightly documentation-sync routine.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YXy9XQTptzYNRB7yFMpVMC