Repository navigation
Fix findings from the nightly PR-review and docs-sync issues - #494
Merged
Merged
Conversation
Hub joins, the live-event flush and the dashboard scope took the same exclusive semaphore as folder mutations, so a backup restore or a move stalled every live event and join. The lock is now a FIFO reader/writer lock: readers share it, mutations and the subscription revalidation stay exclusive, and a waiting mutation is not overtaken by new readers. The notifier bounds its wait for the lock by BatchTimeout and drops the batch if a mutation outlasts it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A startWorkflow/forEach reference that is neither in the backup nor in the database made the whole restore fail. The import writes Guid.Empty for such references on purpose, so a backup of a system holding one could not be restored. The reference now stays as stored. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The reparse-free walk threw on any reparse entry and on any failure to read attributes, also when the watch does not recurse. A junction in the drop folder, a dedup/cloud placeholder or a file deleted mid-scan marked the source unhealthy, so the trigger never fired. A flat scan now skips those entries; recursive watches still reject reparse points. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
They only use fakes or the script AST, but nothing called them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
44.5.1 embeds the same Node (24.21.0) and Chromium (152) as 44.4.5, so the embedded-Node note stays valid. The pin guard, the note and the changelog follow the new version. The lockfile only carries the electron and @types/node entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
DocumentationCountsTests now pins the part count the e2e README quotes (86). Also explains that the manual E2E checklist leaves out automated-only parts, and adds a test that gate.py's UI source hash ignores test files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Quartz 4 fires a skipped time at the end of the gap and fires hourly or more frequent schedules again in the repeated hour. Also lists the new cron parsing rules. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contract defaults read as *** for callers without Edit on the folder. Several allow/bypass/role lists are read whole from the highest-priority provider instead of being merged by index. The redactor fast-path row in performance-improvements.md now matches the current pass structure. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The startup error pointed at docs/custom-activity-key-migration.md, which nothing linked and installations don't ship. The conflict query and procedure are now on the Production deployment page of the documentation website, custom-activities.md links the guide and states the uniqueness rule, and the error message names the website page. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| DeleteDirectoryLink(dirLink); | ||
| try { File.Delete(fileLink); } catch { } | ||
| try { Directory.Delete(stage, recursive: true); } catch { } |
| { | ||
| DeleteDirectoryLink(dirLink); | ||
| try { File.Delete(fileLink); } catch { } | ||
| try { Directory.Delete(stage, recursive: true); } catch { } |
| [WindowsFact] | ||
| public async Task Execute_ManualFlatScan_SkipsLinksInsteadOfFailing() | ||
| { | ||
| var stage = Path.Combine(Path.GetTempPath(), "nodepilot-fw-flat-link-" + Guid.NewGuid().ToString("N")); |
| public async Task Execute_ManualFlatScan_SkipsLinksInsteadOfFailing() | ||
| { | ||
| var stage = Path.Combine(Path.GetTempPath(), "nodepilot-fw-flat-link-" + Guid.NewGuid().ToString("N")); | ||
| var watched = Path.Combine(stage, "watched"); |
| { | ||
| var stage = Path.Combine(Path.GetTempPath(), "nodepilot-fw-flat-link-" + Guid.NewGuid().ToString("N")); | ||
| var watched = Path.Combine(stage, "watched"); | ||
| var outside = Path.Combine(stage, "outside"); |
| var fileLink = Path.Combine(watched, "file-link.log"); | ||
| Directory.CreateDirectory(watched); | ||
| Directory.CreateDirectory(outside); | ||
| await File.WriteAllTextAsync(Path.Combine(watched, "real.log"), "x"); |
| Directory.CreateDirectory(watched); | ||
| Directory.CreateDirectory(outside); | ||
| await File.WriteAllTextAsync(Path.Combine(watched, "real.log"), "x"); | ||
| await File.WriteAllTextAsync(Path.Combine(outside, "outside-secret.log"), "secret"); |
| try | ||
| { | ||
| Directory.CreateSymbolicLink(dirLink, outside); | ||
| File.CreateSymbolicLink(fileLink, Path.Combine(outside, "outside-secret.log")); |
| finally | ||
| { | ||
| DeleteDirectoryLink(dirLink); | ||
| try { File.Delete(fileLink); } catch { } |
| finally | ||
| { | ||
| DeleteDirectoryLink(dirLink); | ||
| try { File.Delete(fileLink); } catch { } |
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works through the open PR-review and docs-sync issues (#472, #473, #475, #476, #478, #483, #491, #493).
Code
BatchTimeoutfor the lock and drops the batch if a mutation outlasts it.Guid.Emptyfrom an import, or a deleted workflow) as stored instead of aborting. A warning would not help here: any restore warning aborts the restore.Guards and docs
DocumentationCountsTestspins the e2e catalogue part count; the e2e README says 86 (same fix as docs: sync after #466 (E2E catalogue Teile count) #474).Known and not changed here:
test_gate.py::test_catalog_is_complete_and_drift_checkedfails on main because coverage-review.json lags the UI sources.Tests run locally: Data.Tests (lock, custom activity key) 17, Api.Tests (restore, notifier, hub, dashboard, settings docs) 265, Engine.Tests (FileWatcher) 67, Mcp.Tests (DocumentationCountsTests) 29, docs-ui 221, desktop package contract 8.
Closes #472, closes #473, closes #475, closes #476, closes #478, closes #483, closes #491, closes #493
🤖 Generated with Claude Code