Skip to content

Implement DnsResolver for Linux #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anurag6569201 wants to merge 1 commit into
base: qa/agent-dotnet-runtime/pr-02-129846/base
Choose a base branch
from
Open

Implement DnsResolver for Linux #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libraries/System.Net.NameResolution/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@
<data name="net_completed_result" xml:space="preserve">
<value>This operation cannot be performed on a completed asynchronous result object.</value>
</data>
<data name="net_io_eof" xml:space="preserve">
<value>Received an unexpected EOF or 0 bytes from the transport stream.</value>
</data>
<data name="net_io_invalidasyncresult" xml:space="preserve">
<value>The IAsyncResult object was not returned from the corresponding asynchronous method on this class.</value>
</data>
Expand Down Expand Up @@ -90,4 +93,7 @@
<data name="net_dns_unsupported_address_family" xml:space="preserve">
<value>Only the InterNetwork and InterNetworkV6 address families are supported.</value>
</data>
</root>
<data name="net_invalid_dns_name" xml:space="preserve">
<value>The DNS name '{0}' is not a valid domain name.</value>
</data>
</root>
14 changes: 13 additions & 1 deletion src/libraries/System.Net.NameResolution/src/System.Net.NameResolution.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@

<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'unix'">
<Compile Include="System\Net\NameResolutionPal.Unix.cs" />
<Compile Include="System\Net\DnsResolverPal.Unsupported.cs" />
<Compile Include="System\Net\DnsResolverPal.Managed.cs" />

@shipwright-agent shipwright-agent Bot Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipwright · HIGH

The new managed DNS resolver (DnsResolverPal.Managed.cs, DnsSocket.cs, ResolvConf.cs) replaces the unsupported stub on Unix.

Impact: The new managed DNS resolver (DnsResolverPal.Managed.cs, DnsSocket.cs, ResolvConf.cs) replaces the unsupported stub on Unix. This is a significant new attack surface: it parses untrusted DNS responses from the network. The diff shows extensive parsing code but no evidence of response validation against the query (transaction ID, question section matching, source address validation). DNS spoofing/cache poisoning is a…

Suggested fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

<Compile Include="System\Net\DnsSocket.cs" />
<Compile Include="System\Net\ResolvConf.cs" />
<Compile Include="System\Net\DnsWireEnums.cs" />
<Compile Include="System\Net\DnsMessageHeader.cs" />
<Compile Include="System\Net\DnsMessageReader.cs" />
<Compile Include="System\Net\DnsMessageWriter.cs" />
<Compile Include="System\Net\DnsEncodedName.cs" />
<Compile Include="System\Net\DnsRecordParsing.cs" />
<Compile Include="$(CommonPath)System\Net\InteropIPAddressExtensions.Unix.cs"
Link="Common\System\Net\InteropIPAddressExtensions.Unix.cs" />
<Compile Include="$(CommonPath)System\Net\SocketAddressPal.Unix.cs"
Expand Down Expand Up @@ -169,4 +177,8 @@
<ProjectReference Include="$(LibrariesProjectRoot)System.Threading.ThreadPool\src\System.Threading.ThreadPool.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'unix'">
<ProjectReference Include="$(LibrariesProjectRoot)System.Security.Cryptography\src\System.Security.Cryptography.csproj" />
</ItemGroup>

</Project>
Loading