Always show the footer in dev, by keeping the task display running#2417
Merged
Conversation
Contributor
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Contributor
Coverage report
Test suite run success1292 tests passing in 637 suites. Report generated by 🧪jest coverage report action from 029b497 |
matteodepalo
approved these changes
Jul 13, 2023
This comment has been minimized.
This comment has been minimized.
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/ui/components/ConcurrentOutput.d.ts@@ -18,6 +18,7 @@ export interface ConcurrentOutputProps {
shortcuts: Shortcut[];
subTitle?: string;
};
+ keepRunningAfterProcessesResolve?: boolean;
}
/**
* Renders output from concurrent processes to the terminal.
|
MitchLillie
added a commit
that referenced
this pull request
Apr 16, 2026
When processBatch threw, the while loop exited and any events already queued during the failing batch were orphaned — stuck in this.queue until the next enqueue() call. This caused the dev session pipeline to silently stop processing updates after a transient error (e.g. network timeout, GraphQL error), matching the symptom in issue #2417 where hot reloading stops after ~12-15 changes. Fix: catch errors inside the while loop so the processor continues draining queued items. Fatal errors should be thrown by the caller (e.g. DevSession) to terminate the process, not by the batch processor. Also fix bundleExtensionsAndUpload: non-auth ClientError responses now return {status: 'unknown-error'} instead of throwing AbortError, keeping the error in the normal result flow (logged, added to failedEvents for retry on next change).
MitchLillie
added a commit
that referenced
this pull request
Apr 16, 2026
Tracing: every file change gets a monotonic [build:N] ID that traces
through the full pipeline in --verbose output. Logs at every stage:
onChange → handleWatcherEvents → buildExtensions → generateExtensionTypes
→ emit('all') → DevSession.onEvent → validateAppEvent → processEvents
→ bundleExtensionsAndUpload → result
Levers (env vars to isolate the permanent failure in #2417):
DEV_SKIP_GENERATE_TYPES=1
Skip generateExtensionTypes() after build. Tests if this call
hangs and permanently blocks emit('all').
DEV_SKIP_RESCAN_IMPORTS=1
Skip rescanImports() which can restart the file watcher. Tests
if a watcher restart during vite mid-write permanently loses
the admin extension's watched files.
DEV_SERIALIZE_ONCHANGE=1
Serialize onChange handlers with a mutex. Tests if concurrent
.then() chains corrupting shared state (this.app, bundle dir)
cause the permanent break.
DEV_UPLOAD_TIMEOUT_MS=15000
Add a timeout to bundleExtensionsAndUpload. Tests if a hung
GCS upload or API call permanently blocks the SerialBatchProcessor.
MitchLillie
added a commit
that referenced
this pull request
Apr 16, 2026
Toggles source code strings in a hosted app every N seconds to trigger repeated vite rebuilds. Used alongside the diagnostic levers to isolate the permanent failure in #2417.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Ensures that we are consistent in showing the preview footer in dev
WHAT is this pull request doing?
Keeps the dev task list open, with its footer, even when the tasks have completed running.
How to test your changes?
Init a "none" app, and add a subscription ui extension. Run dev and observe that the footer is displayed and can be previewed with (p)
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.