Skip to content

Don't use cached config name when using --reset #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacroldan merged 1 commit into from
Apr 25, 2025
Merged

Don't use cached config name when using --reset #5676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-kings-add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Fix issue when using `--reset` not creating a new config toml file
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/app-context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ describe('linkedAppContext', () => {
})

// Then
expect(link).toHaveBeenCalledWith({directory: tmp, apiKey: undefined, configName: 'shopify.app.toml'})
expect(link).toHaveBeenCalledWith({directory: tmp, apiKey: undefined, configName: undefined})
})
})

Expand Down
4 changes: 3 additions & 1 deletion packages/app/src/cli/services/app-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ export async function linkedAppContext({

// If the app is not linked, force a link.
if (configState.state === 'template-only' || forceRelink) {
const result = await link({directory, apiKey: clientId, configName: configState.configurationFileName})
// If forceRelink is true, we don't want to use the cached config name and instead prompt the user for a new one.
const configName = forceRelink ? undefined : configState.configurationFileName
const result = await link({directory, apiKey: clientId, configName})
remoteApp = result.remoteApp
configState = result.state
}
Expand Down