Run web build commands during deploy for hosted apps by MitchLillie · Pull Request #7208 · Shopify/cli

MitchLillie · 2026-04-06T22:46:06Z

Closes https://github.com/shop/issues-admin-extensibility/issues/2398

Summary

bundleAndBuildExtensions now runs web.toml build commands concurrently alongside extension bundling during shopify app deploy
Scoped to webs that explicitly define a build command — extension-only apps and dev-only webs are unaffected
Respects --no-build / skipBuild flag

Root cause: deploy called bundleAndBuildExtensions (extensions only) but never invoked buildWeb('build', ...), unlike shopify app build which does. Users had to manually run build before deploy.

Closes shop/issues-admin-extensibility#2398

Manual test instructions

Setup: You need an app with a web/ directory and a web.toml that defines a build command:

# web/web.toml
[commands]
dev = "npm run dev"
build = "npm run build"

Test: build command runs on deploy

Make a change to your web app source that only reflects after a build
Run shopify app deploy
Confirm your build command output appears in the concurrent output alongside extensions
Confirm the deploy succeeds

Test: --no-build skips web build

Run shopify app deploy --no-build
Confirm the build command does NOT run (no web-prefixed process in output)

Test: extension-only apps unaffected

Use an app whose web.toml has no build command (or no webs at all)
Run shopify app deploy — confirm no new web-prefixed process appears in output

Test plan

runs web build command concurrently with extensions when build command is defined
skips web build for webs without a build command defined
skips web build command when skipBuild is true
Manual test with a hosted app
Manual test with --no-build

🤖 Generated with Claude Code

github-actions · 2026-04-06T23:15:53Z

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

isaacroldan

Approving but please apply the suggested formatting changes :)

When a web.toml defines a `build` command, deploy now runs it concurrently alongside extension bundling. Previously users had to manually run `shopify app build` before `shopify app deploy` to ensure web assets were up to date. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

This reverts all changes from the hosted app project (Admin Extensibility → 'hosted app' sub-project). The hosted app project is being discontinued. This PR removes: - The admin extension specification (static_root, allowed_domains) - The HOSTED_APPS environment variable and template switching - Web build execution during deploy - Template application_url preservation during app creation - Admin-specific dev server asset serving What's preserved: - Asset upload infrastructure (include_assets client step) - used by other extension types - admin_link specification - separate extension type for admin links with intents - Client steps system - general build pipeline infrastructure - devSessionWatchConfig - general watch path infrastructure Reverted PRs: - #7027 - Add admin hosted app local spec - #7096 - Switch app init template to hosted app when HOSTED_APPS env var is set - #7208 - Run web build commands during deploy for hosted apps - #7225 - Preserve template application_url during app creation - #7227 - notify extension dev server of app assets updates (admin parts only) - #7312 - Default allowed_domains to empty array when not configured

This reverts most changes from the hosted app project (Admin Extensibility → "hosted app" sub-project). The hosted app project is being discontinued. This PR removes: - The `admin` extension specification (`admin.ts` with `static_root`, `allowed_domains`) - Web build execution during deploy - Template `application_url`/`redirect_urls` preservation during app creation - Admin-specific dev server asset serving (`getAppAssets`, `allowedDomains` in payload) What is preserved: - `HOSTED_APPS` environment variable and `isHostedAppsMode()` function - `buildNoneTemplate()` with conditional template selection (uses extension-only template when `HOSTED_APPS=1`) - Asset upload infrastructure (`include_assets` client step) - used by other extension types - `admin_link` specification - separate extension type for admin links with intents - `assetResolvers` in dev server store - per-extension URL→path mapping - Client steps system - general build pipeline infrastructure Reverted PRs: - #7027 - Add admin hosted app local spec - #7096 - Switch app init template (partially - kept template switching, removed other hosted app setup) - #7208 - Run web build commands during deploy for hosted apps - #7225 - Preserve template application_url during app creation - #7227 - Notify extension dev server of app assets updates (admin parts only) - #7312 - Default allowed_domains to empty array when not configured

MitchLillie marked this pull request as ready for review April 6, 2026 23:15

MitchLillie requested a review from a team as a code owner April 6, 2026 23:15

MitchLillie force-pushed the cx-ensure-build-runs-before-deploy branch from ebb92da to e31511b Compare April 7, 2026 17:11

MitchLillie requested a review from a team as a code owner April 7, 2026 17:11

MitchLillie force-pushed the cx-ensure-build-runs-before-deploy branch 2 times, most recently from ae4d442 to 36df04d Compare April 13, 2026 16:22

isaacroldan reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/app/src/cli/services/deploy/bundle.ts

isaacroldan reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/app/src/cli/services/deploy/bundle.ts Outdated

isaacroldan approved these changes Apr 13, 2026

View reviewed changes

MitchLillie force-pushed the cx-ensure-build-runs-before-deploy branch from 36df04d to 93234bd Compare April 13, 2026 17:03

MitchLillie enabled auto-merge April 13, 2026 19:44

MitchLillie force-pushed the cx-ensure-build-runs-before-deploy branch from 93234bd to 80cdab8 Compare April 13, 2026 19:45

MitchLillie added this pull request to the merge queue Apr 13, 2026

Merged via the queue into main with commit 45cdabf Apr 13, 2026
25 checks passed

MitchLillie deleted the cx-ensure-build-runs-before-deploy branch April 13, 2026 20:00

MitchLillie mentioned this pull request Apr 21, 2026

Revert hosted app project changes #7361

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run web build commands during deploy for hosted apps#7208

Run web build commands during deploy for hosted apps#7208
MitchLillie merged 1 commit into
mainfrom
cx-ensure-build-runs-before-deploy

MitchLillie commented Apr 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

isaacroldan left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MitchLillie commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Manual test instructions

Test plan

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

isaacroldan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MitchLillie commented Apr 6, 2026 •

edited

Loading