Use validated storefront password for theme apps#7662
Merged
Conversation
ensureValidPassword now treats an empty string as a provided password, so passing '' from the app dev flow skips the normal prompt/local storage fallback. Pass undefined instead so password-protected stores use the same validation path as theme dev, and keep the returned password on the theme app extension process options.
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260528213307Caution After installing, validate the version by running |
EvilGenius13
approved these changes
May 29, 2026
EvilGenius13
left a comment
EvilGenius13
left a comment
Contributor
There was a problem hiding this comment.
🎩 on current CLI vs the snapshot, works great!
dmerand
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
ensureValidPasswordnow treats an empty string as a provided password (#7010), so passing''from theapp devflow skips the normal prompt/local storage fallback.Pass
undefinedinstead so password-protected stores use the same validation path astheme dev, and keep the returned password on the theme app extension process options.How to test your changes?
shopify app devagainst a shop that has a storefront password