Skip to content

Fix deploy not working when using --no-build#7903

Merged
isaacroldan merged 1 commit into
mainfrom
06-23-fix_deploy_not_working_when_using_--no-build
Jun 23, 2026
Merged

Fix deploy not working when using --no-build#7903
isaacroldan merged 1 commit into
mainfrom
06-23-fix_deploy_not_working_when_using_--no-build

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Why

app deploy --no-build used a separate copy path that no longer matched the extension bundle build path.

What

  • Route deploy bundling through buildForBundle and pass skipBuild through.
  • Make UI and function builders reuse existing output when skipBuild is set.
  • Remove copyIntoBundle and update bundle tests.

Testing

  • pnpm vitest packages/app/src/cli/services/deploy/bundle.test.ts packages/app/src/cli/models/extensions/extension-instance.test.ts --run
  • pnpm --filter @shopify/app lint
  • pnpm --filter @shopify/app type-check

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Jun 23, 2026
@isaacroldan isaacroldan force-pushed the 06-23-fix_deploy_not_working_when_using_--no-build branch 2 times, most recently from 5d21c71 to d53f3a7 Compare June 23, 2026 10:07
@isaacroldan isaacroldan force-pushed the 06-23-fix_deploy_not_working_when_using_--no-build branch from d53f3a7 to e1a5d65 Compare June 23, 2026 10:12
@isaacroldan isaacroldan marked this pull request as ready for review June 23, 2026 10:12
@isaacroldan isaacroldan requested review from a team as code owners June 23, 2026 10:12
@isaacroldan isaacroldan added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit e2fb757 Jun 23, 2026
28 checks passed
@isaacroldan isaacroldan deleted the 06-23-fix_deploy_not_working_when_using_--no-build branch June 23, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants