Remove unnecessary execution_time_us assertions - #93
Merged
Conversation
adampetro
approved these changes
Jan 22, 2026
jeffcharles
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/shop/issues-shopifyvm/issues/844
In a recent build, we noticed that there was a failure in the
defaults_to_counting_all_instructionstest due toexecution_time_usbeing 3 instead of 0. This assertion doesn't make sense for this test since the test is about instruction counts. It also doesn't add value to check that it's >= 0, since that's a guarantee for auint64.I've also removed this assertion in
can_bypass_deserialization_instructionsfor a similar reason.