Conversation
| [access_scopes] | ||
| # Learn more at https://shopify.dev/docs/apps/tools/cli/configuration#access_scopes | ||
| scopes = "customer_read_customers,customer_read_orders,customer_read_own_subscription_contracts,customer_write_customers,customer_write_own_subscription_contracts,read_all_orders,read_locales,read_locations,read_themes,write_customer_payment_methods,write_customers,write_metaobject_definitions,write_metaobjects,write_orders,write_own_subscription_contracts,write_products,write_translations, read_analytics" | ||
| scopes = "read_locales,read_locations,read_themes,write_customers,write_metaobject_definitions,write_metaobjects,write_orders,write_products,write_translations,read_analytics" |
There was a problem hiding this comment.
What's the reason for updating the scopes? Could you update the PR description to mention why these needed to be updated, please?
| "@graphql-codegen/cli": "5.0.7", | ||
| "@graphql-codegen/introspection": "4.0.3", | ||
| "@iarna/toml": "2.2.5", | ||
| "@remix-run/eslint-config": "2.16.8", |
There was a problem hiding this comment.
How's the linting executed after removing the @remix-run/eslint-config?
There was a problem hiding this comment.
According to claude: @remix-run/eslint-config wasn't actually used anywhere — the project already uses an ESLint 9 flat config (eslint.config.js) that configures all the linting rules directly via @typescript-eslint, eslint-plugin-react, eslint-plugin-react-hooks, eslint-plugin-jsx-a11y, eslint-plugin-testing-library, eslint-plugin-jest-dom, and eslint-config-prettier. The @remix-run/eslint-config package was just a leftover dependency that only supported ESLint 8, which made it impossible to install with npm due to the peer dependency conflict with @shopify/eslint-plugin@50 (requires ESLint 9). Removing it has no effect on linting behavio
|
|
||
| [access_scopes] | ||
| # Learn more at https://shopify.dev/docs/apps/tools/cli/configuration#access_scopes | ||
| scopes = "customer_read_customers,customer_read_orders,customer_read_own_subscription_contracts,customer_write_customers,customer_write_own_subscription_contracts,read_all_orders,read_locales,read_locations,read_themes,write_customer_payment_methods,write_customers,write_metaobject_definitions,write_metaobjects,write_orders,write_own_subscription_contracts,write_products,write_translations, read_analytics" |
There was a problem hiding this comment.
This is removing subscription-critical scopes. For a subscriptions reference app, these seem essential for creating/managing subscription contracts and processing customer payments.
There was a problem hiding this comment.
These scopes throw when trying to run shopify app init --template https://github.com/Shopify/subscriptions-reference-app. I don't have any context here. Was just trying to fix the fact that this template isn't usable currently. Happy for you to test and let me know what's needed though
christineawalsh
left a comment
christineawalsh
left a comment
There was a problem hiding this comment.
Sorry to block this - can we double check whether we should remove these access scopes?
|
@christineawalsh @metamoni Happy for you folks to take this on. As it stands this template is unusable in the shopify CLI without these changes. Since you folks have the expertise in this space, I'll leave it to you to resolve. 🙂 |
6 participants
This pull request makes a minor update to the project's dependencies by removing the
@remix-run/eslint-configpackage from thepackage.jsonfile. This change helps streamline the project's dependency list.