Repository navigation
feat(ui): let the rows leave out their line counts - #61
Merged
Merged
Conversation
The bars checkbox becomes Numbers, Bars and None, so a reader who takes the sizes from the thickness, the chart or the calendar can give the rows' room to the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each row shows its commit's lines added and deleted, as numbers or as bars, and the same counts already show as the graph's thickness, in the chart of lines over time and in the calendar. A reader who takes the sizes from those has no way to give the rows' room back to the summary and the other details. The decisions are in ADR 0052.
The setting
The bars checkbox becomes a group of its own with Numbers, Bars and None, right under the graph's settings (App.tsx); Numbers is the default. With None a row draws neither the numbers nor the bars, and keeps no room for the bars (RepoCard.tsx). The counts are still loaded, since the thickness, the chart, the calendar and the commit details read them. The command palette offers each choice, as it does for the date format, in place of the bars toggle (App.tsx).
The choice is saved under
gitreant-line-counts. Where nothing is saved there yet, bars saved by the old checkbox undergitreant-line-barsread as Bars, and anything else as Numbers (parseLineCounts).Tests