Skip to content

feat(ui): let the rows leave out their line counts - #61

Merged
ShortArrow merged 2 commits into
mainfrom
feat/line-counts-off
Oct 28, 2026
Merged

ShortArrow merged 2 commits into
mainfrom
feat/line-counts-off

Conversation

@ShortArrow

@ShortArrow ShortArrow commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Why

Each row shows its commit's lines added and deleted, as numbers or as bars, and the same counts already show as the graph's thickness, in the chart of lines over time and in the calendar. A reader who takes the sizes from those has no way to give the rows' room back to the summary and the other details. The decisions are in ADR 0052.

The setting

The bars checkbox becomes a group of its own with Numbers, Bars and None, right under the graph's settings (App.tsx); Numbers is the default. With None a row draws neither the numbers nor the bars, and keeps no room for the bars (RepoCard.tsx). The counts are still loaded, since the thickness, the chart, the calendar and the commit details read them. The command palette offers each choice, as it does for the date format, in place of the bars toggle (App.tsx).

The choice is saved under gitreant-line-counts. Where nothing is saved there yet, bars saved by the old checkbox under gitreant-line-bars read as Bars, and anything else as Numbers (parseLineCounts).

Tests

  • Unit test: reading the saved choice, and falling back to the old checkbox.
  • E2E: the bars test now picks Bars and Numbers from the group; a new test picks None, finds no counts in the rows with the summaries where they were, and keeps None across a reload. Both failed before the change. The test that counts the settings' segmented groups now expects four.

The bars checkbox becomes Numbers, Bars and None, so a reader who takes the sizes from the thickness, the chart or the calendar can give the rows' room to the rest.
@ShortArrow
ShortArrow marked this pull request as ready for review October 28, 2026 00:24
@ShortArrow
ShortArrow merged commit cc54e8b into main Oct 28, 2026
15 checks passed
@ShortArrow
ShortArrow deleted the feat/line-counts-off branch October 28, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant