You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug] Market card shows carrier callsign, not the carrier name #90
Part of the Phase 1 backlog (#87). Milestone: Phase 4 — Market & routes.
Summary
When docked on a fleet carrier, the Market card's title shows the carrier's callsign / dashed
designation (e.g. K7Q-B3L) instead of the carrier's chosen name. It should show the friendly
name, and ideally in the form:
<Carrier Name> (<current system the carrier is in>)
e.g. Nomad's Reach (HIP 23759).
Why it happens
The journal's Docked event reports StationName as the carrier callsign for a fleet carrier;
the carrier's chosen name is not on Docked. The chain that surfaces the title never has the name:
StateTracker.OnDocked stores e.GetString("StationName") into CommanderState.StationName
(src/EDNexus.Core/State/StateTracker.cs:118-122) — that's the callsign for a carrier.
MarketTracker.OnMarket stamps StationName = e.GetString("StationName") ?? _state?.StationName
into the snapshot (src/EDNexus.Core/Market/MarketTracker.cs:71).
Nothing captures CarrierStats.Name or the Docked.StationType == "FleetCarrier" flag, so the
callsign is all the card has.
Fix sketch
Capture the carrier name and callsign — CarrierStats carries Name + Callsign; the Docked/Location events carry StationType (FleetCarrier) and StationName (callsign).
Store carrier name/callsign (and "am I currently docked on my/a carrier") on CommanderState.
When the docked station is a fleet carrier, render the title as Name (System), falling back to
the callsign when the name isn't known yet.
Consider showing Name [Callsign] or a tooltip so the callsign is still discoverable.
Notes
Applies to any carrier, not just the commander's own (other players' carriers report a StationType of FleetCarrier too, but only the callsign is guaranteed — name may be unknown).
Same title logic likely wants reuse anywhere else we show a docked-station name (location card).
Activity