Skip to content

Fix swapped out parameters in Base64Url.DecodeFromUtf8 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 3 commits into from
Oct 12, 2026
Merged

Fix swapped out parameters in Base64Url.DecodeFromUtf8 #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0567ca5
Fix swapped out parameters in Base64Url.DecodeFromUtf8
SimonCropp Oct 11, 2026
17bc558
Regenerate docs
SimonCropp Oct 12, 2026
c86790b
Docs changes
actions-user Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assemblySize.include.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
| netcoreapp2.0 | 9.0KB | 560.8KB | +551.8KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.1 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp2.2 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp3.0 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.1 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.0 | 9.5KB | 501.9KB | +492.4KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.1 | 9.5KB | 501.9KB | +492.4KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| net5.0 | 9.5KB | 449.4KB | +439.9KB | +16.1KB | +8.2KB | +13.9KB | +18.9KB |
| net6.0 | 10.0KB | 367.6KB | +357.6KB | +17.1KB | +8.2KB | +1.1KB | +3.7KB |
| net7.0 | 10.0KB | 320.2KB | +310.2KB | +17.0KB | +6.9KB | +1.1KB | +4.2KB |
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ Only [SDK-style projects](https://learn.microsoft.com/en-us/dotnet/core/project-
| netcoreapp2.0 | 9.0KB | 560.8KB | +551.8KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.1 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp2.2 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp3.0 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.1 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.0 | 9.5KB | 501.9KB | +492.4KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.1 | 9.5KB | 501.9KB | +492.4KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| net5.0 | 9.5KB | 449.4KB | +439.9KB | +16.1KB | +8.2KB | +13.9KB | +18.9KB |
| net6.0 | 10.0KB | 367.6KB | +357.6KB | +17.1KB | +8.2KB | +1.1KB | +3.7KB |
| net7.0 | 10.0KB | 320.2KB | +310.2KB | +17.0KB | +6.9KB | +1.1KB | +4.2KB |
Expand Down
2 changes: 1 addition & 1 deletion src/Polyfill/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net461/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net462/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net47/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net471/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net472/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net48/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net481/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net5.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net6.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net7.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/net8.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netcoreapp2.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netcoreapp2.1/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netcoreapp2.2/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netcoreapp3.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netcoreapp3.1/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netstandard2.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/netstandard2.1/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Split/uap10.0/Base64Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static int DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destinati
public static OperationStatus DecodeFromUtf8(ReadOnlySpan<byte> source, Span<byte> destination, out int bytesConsumed, out int bytesWritten, bool isFinalBlock = true)
{
var chars = BytesToChars(source);
var status = DecodeFromChars(chars, destination, out bytesWritten, out var charsConsumed, isFinalBlock);
var status = DecodeFromChars(chars, destination, out var charsConsumed, out bytesWritten, isFinalBlock);
bytesConsumed = charsConsumed;
return status;
}
Expand Down
11 changes: 11 additions & 0 deletions src/Tests/Base64UrlTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,17 @@ public async Task DecodeFromChars_OperationStatus_Blocks()
await Assert.That(consumed).IsEqualTo(4);
await Assert.That(written).IsEqualTo(3);
}

[Test]
public async Task DecodeFromUtf8_OperationStatus_Done()
{
var destination = new byte[20];
var status = Base64Url.DecodeFromUtf8("AQID"u8, destination, out var bytesConsumed, out var bytesWritten);
await Assert.That(status).IsEqualTo(OperationStatus.Done);
await Assert.That(bytesConsumed).IsEqualTo(4);
await Assert.That(bytesWritten).IsEqualTo(3);
await Assert.That(destination.AsSpan(0, 3).ToArray()).IsEquivalentTo(new byte[] {1, 2, 3});
}
}

#endif
Loading