Skip to content

Throw FormatException from Base64.TryDecodeFromChars for invalid input #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 3 commits into from
Oct 11, 2026
Merged

Throw FormatException from Base64.TryDecodeFromChars for invalid input #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
093e756
Throw FormatException from Base64.TryDecodeFromChars for invalid input
SimonCropp Oct 11, 2026
f35a680
Regenerate docs
SimonCropp Oct 11, 2026
704d448
Docs changes
actions-user Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions assemblySize.include.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
| | Empty Assembly | With Polyfill | Diff | Ensure | ArgumentExceptions | StringInterpolation | Nullability |
|----------------|----------------|---------------|-----------|-----------|--------------------|---------------------|-------------|
| netstandard2.0 | 8.0KB | 406.5KB | +398.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| netstandard2.1 | 8.5KB | 352.0KB | +343.5KB | +8.5KB | +6.0KB | +8.5KB | +13.5KB |
| net461 | 8.5KB | 405.0KB | +396.5KB | +9.0KB | +7.0KB | +9.5KB | +14.5KB |
| netstandard2.1 | 8.5KB | 351.5KB | +343.0KB | +9.0KB | +6.5KB | +9.0KB | +14.0KB |
| net461 | 8.5KB | 405.0KB | +396.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| net462 | 7.0KB | 408.5KB | +401.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| net47 | 7.0KB | 408.5KB | +401.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| net471 | 8.5KB | 407.5KB | +399.0KB | +9.0KB | +7.0KB | +9.5KB | +14.5KB |
Expand All @@ -16,10 +16,10 @@
| netcoreapp2.2 | 9.0KB | 361.5KB | +352.5KB | +7.5KB | +5.5KB | +8.0KB | +13.0KB |
| netcoreapp3.0 | 9.5KB | 350.0KB | +340.5KB | +8.0KB | +6.5KB | +9.5KB | +14.0KB |
| netcoreapp3.1 | 9.5KB | 350.0KB | +340.5KB | +8.0KB | +6.5KB | +9.5KB | +14.0KB |
| net5.0 | 9.5KB | 315.5KB | +306.0KB | +9.0KB | +6.5KB | +9.0KB | +13.5KB |
| net5.0 | 9.5KB | 315.5KB | +306.0KB | +8.5KB | +6.5KB | +9.0KB | +13.5KB |
| net6.0 | 10.0KB | 255.0KB | +245.0KB | +9.5KB | +6.5KB | +512bytes | +3.0KB |
| net7.0 | 10.0KB | 224.5KB | +214.5KB | +9.5KB | +6.0KB | +512bytes | +3.5KB |
| net8.0 | 9.5KB | 196.0KB | +186.5KB | +8.0KB | | +512bytes | +3.0KB |
| net7.0 | 10.0KB | 224.5KB | +214.5KB | +9.5KB | +5.5KB | +512bytes | +3.5KB |
| net8.0 | 9.5KB | 195.5KB | +186.0KB | +8.5KB | +512bytes | +1.0KB | +3.5KB |
| net9.0 | 9.5KB | 126.0KB | +116.5KB | +8.5KB | | +512bytes | +3.5KB |
| net10.0 | 10.0KB | 100.0KB | +90.0KB | +8.5KB | | +512bytes | +3.5KB |
| net11.0 | 10.0KB | 17.5KB | +7.5KB | +9.0KB | | +512bytes | +3.5KB |
Expand All @@ -30,23 +30,23 @@
| | Empty Assembly | With Polyfill | Diff | Ensure | ArgumentExceptions | StringInterpolation | Nullability |
|----------------|----------------|---------------|-----------|-----------|--------------------|---------------------|-------------|
| netstandard2.0 | 8.0KB | 593.8KB | +585.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| netstandard2.1 | 8.5KB | 507.2KB | +498.7KB | +16.1KB | +7.7KB | +13.4KB | +18.9KB |
| net461 | 8.5KB | 593.4KB | +584.9KB | +16.6KB | +8.7KB | +14.4KB | +19.9KB |
| net462 | 7.0KB | 596.9KB | +589.9KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net47 | 7.0KB | 596.9KB | +589.9KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net471 | 8.5KB | 595.3KB | +586.8KB | +16.6KB | +8.7KB | +14.4KB | +19.9KB |
| netstandard2.1 | 8.5KB | 506.6KB | +498.1KB | +16.6KB | +8.2KB | +13.9KB | +19.4KB |
| net461 | 8.5KB | 593.3KB | +584.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net462 | 7.0KB | 596.8KB | +589.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net47 | 7.0KB | 596.8KB | +589.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net471 | 8.5KB | 595.2KB | +586.7KB | +16.6KB | +8.7KB | +14.4KB | +19.9KB |
| net472 | 8.5KB | 593.2KB | +584.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| net48 | 8.5KB | 593.2KB | +584.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| net481 | 8.5KB | 593.2KB | +584.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.0 | 9.0KB | 560.8KB | +551.8KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.0 | 9.0KB | 560.7KB | +551.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.1 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp2.2 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp3.0 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.1 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| net5.0 | 9.5KB | 449.5KB | +440.0KB | +16.6KB | +8.2KB | +13.9KB | +18.9KB |
| net5.0 | 9.5KB | 449.4KB | +439.9KB | +16.1KB | +8.2KB | +13.9KB | +18.9KB |
| net6.0 | 10.0KB | 367.6KB | +357.6KB | +17.1KB | +8.2KB | +1.1KB | +3.7KB |
| net7.0 | 10.0KB | 320.3KB | +310.3KB | +17.0KB | +7.4KB | +1.1KB | +4.2KB |
| net8.0 | 9.5KB | 277.2KB | +267.7KB | +15.4KB | +299bytes | +1.1KB | +3.7KB |
| net9.0 | 9.5KB | 180.8KB | +171.3KB | +15.9KB | | +1.1KB | +4.2KB |
| net7.0 | 10.0KB | 320.2KB | +310.2KB | +17.0KB | +6.9KB | +1.1KB | +4.2KB |
| net8.0 | 9.5KB | 276.7KB | +267.2KB | +15.9KB | +811bytes | +1.6KB | +4.2KB |
| net9.0 | 9.5KB | 180.7KB | +171.2KB | +15.9KB | | +1.1KB | +4.2KB |
| net10.0 | 10.0KB | 143.9KB | +133.9KB | +15.9KB | | +1.1KB | +4.2KB |
| net11.0 | 10.0KB | 25.7KB | +15.7KB | +16.4KB | | +1.1KB | +4.2KB |
30 changes: 15 additions & 15 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ Only [SDK-style projects](https://learn.microsoft.com/en-us/dotnet/core/project-
| | Empty Assembly | With Polyfill | Diff | Ensure | ArgumentExceptions | StringInterpolation | Nullability |
|----------------|----------------|---------------|-----------|-----------|--------------------|---------------------|-------------|
| netstandard2.0 | 8.0KB | 406.5KB | +398.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| netstandard2.1 | 8.5KB | 352.0KB | +343.5KB | +8.5KB | +6.0KB | +8.5KB | +13.5KB |
| net461 | 8.5KB | 405.0KB | +396.5KB | +9.0KB | +7.0KB | +9.5KB | +14.5KB |
| netstandard2.1 | 8.5KB | 351.5KB | +343.0KB | +9.0KB | +6.5KB | +9.0KB | +14.0KB |
| net461 | 8.5KB | 405.0KB | +396.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| net462 | 7.0KB | 408.5KB | +401.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| net47 | 7.0KB | 408.5KB | +401.5KB | +9.0KB | +6.5KB | +9.5KB | +14.5KB |
| net471 | 8.5KB | 407.5KB | +399.0KB | +9.0KB | +7.0KB | +9.5KB | +14.5KB |
Expand All @@ -115,10 +115,10 @@ Only [SDK-style projects](https://learn.microsoft.com/en-us/dotnet/core/project-
| netcoreapp2.2 | 9.0KB | 361.5KB | +352.5KB | +7.5KB | +5.5KB | +8.0KB | +13.0KB |
| netcoreapp3.0 | 9.5KB | 350.0KB | +340.5KB | +8.0KB | +6.5KB | +9.5KB | +14.0KB |
| netcoreapp3.1 | 9.5KB | 350.0KB | +340.5KB | +8.0KB | +6.5KB | +9.5KB | +14.0KB |
| net5.0 | 9.5KB | 315.5KB | +306.0KB | +9.0KB | +6.5KB | +9.0KB | +13.5KB |
| net5.0 | 9.5KB | 315.5KB | +306.0KB | +8.5KB | +6.5KB | +9.0KB | +13.5KB |
| net6.0 | 10.0KB | 255.0KB | +245.0KB | +9.5KB | +6.5KB | +512bytes | +3.0KB |
| net7.0 | 10.0KB | 224.5KB | +214.5KB | +9.5KB | +6.0KB | +512bytes | +3.5KB |
| net8.0 | 9.5KB | 196.0KB | +186.5KB | +8.0KB | | +512bytes | +3.0KB |
| net7.0 | 10.0KB | 224.5KB | +214.5KB | +9.5KB | +5.5KB | +512bytes | +3.5KB |
| net8.0 | 9.5KB | 195.5KB | +186.0KB | +8.5KB | +512bytes | +1.0KB | +3.5KB |
| net9.0 | 9.5KB | 126.0KB | +116.5KB | +8.5KB | | +512bytes | +3.5KB |
| net10.0 | 10.0KB | 100.0KB | +90.0KB | +8.5KB | | +512bytes | +3.5KB |
| net11.0 | 10.0KB | 17.5KB | +7.5KB | +9.0KB | | +512bytes | +3.5KB |
Expand All @@ -129,24 +129,24 @@ Only [SDK-style projects](https://learn.microsoft.com/en-us/dotnet/core/project-
| | Empty Assembly | With Polyfill | Diff | Ensure | ArgumentExceptions | StringInterpolation | Nullability |
|----------------|----------------|---------------|-----------|-----------|--------------------|---------------------|-------------|
| netstandard2.0 | 8.0KB | 593.8KB | +585.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| netstandard2.1 | 8.5KB | 507.2KB | +498.7KB | +16.1KB | +7.7KB | +13.4KB | +18.9KB |
| net461 | 8.5KB | 593.4KB | +584.9KB | +16.6KB | +8.7KB | +14.4KB | +19.9KB |
| net462 | 7.0KB | 596.9KB | +589.9KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net47 | 7.0KB | 596.9KB | +589.9KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net471 | 8.5KB | 595.3KB | +586.8KB | +16.6KB | +8.7KB | +14.4KB | +19.9KB |
| netstandard2.1 | 8.5KB | 506.6KB | +498.1KB | +16.6KB | +8.2KB | +13.9KB | +19.4KB |
| net461 | 8.5KB | 593.3KB | +584.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net462 | 7.0KB | 596.8KB | +589.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net47 | 7.0KB | 596.8KB | +589.8KB | +16.6KB | +8.2KB | +14.4KB | +19.9KB |
| net471 | 8.5KB | 595.2KB | +586.7KB | +16.6KB | +8.7KB | +14.4KB | +19.9KB |
| net472 | 8.5KB | 593.2KB | +584.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| net48 | 8.5KB | 593.2KB | +584.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| net481 | 8.5KB | 593.2KB | +584.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.0 | 9.0KB | 560.8KB | +551.8KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.0 | 9.0KB | 560.7KB | +551.7KB | +16.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp2.1 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp2.2 | 9.0KB | 523.9KB | +514.9KB | +15.1KB | +7.2KB | +12.9KB | +18.4KB |
| netcoreapp3.0 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| netcoreapp3.1 | 9.5KB | 502.0KB | +492.5KB | +15.6KB | +8.2KB | +14.4KB | +19.4KB |
| net5.0 | 9.5KB | 449.5KB | +440.0KB | +16.6KB | +8.2KB | +13.9KB | +18.9KB |
| net5.0 | 9.5KB | 449.4KB | +439.9KB | +16.1KB | +8.2KB | +13.9KB | +18.9KB |
| net6.0 | 10.0KB | 367.6KB | +357.6KB | +17.1KB | +8.2KB | +1.1KB | +3.7KB |
| net7.0 | 10.0KB | 320.3KB | +310.3KB | +17.0KB | +7.4KB | +1.1KB | +4.2KB |
| net8.0 | 9.5KB | 277.2KB | +267.7KB | +15.4KB | +299bytes | +1.1KB | +3.7KB |
| net9.0 | 9.5KB | 180.8KB | +171.3KB | +15.9KB | | +1.1KB | +4.2KB |
| net7.0 | 10.0KB | 320.2KB | +310.2KB | +17.0KB | +6.9KB | +1.1KB | +4.2KB |
| net8.0 | 9.5KB | 276.7KB | +267.2KB | +15.9KB | +811bytes | +1.6KB | +4.2KB |
| net9.0 | 9.5KB | 180.7KB | +171.2KB | +15.9KB | | +1.1KB | +4.2KB |
| net10.0 | 10.0KB | 143.9KB | +133.9KB | +15.9KB | | +1.1KB | +4.2KB |
| net11.0 | 10.0KB | 25.7KB | +15.7KB | +16.4KB | | +1.1KB | +4.2KB |
<!-- endInclude -->
Expand Down
20 changes: 6 additions & 14 deletions src/Polyfill/Base64Polyfill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,25 +177,17 @@ public static OperationStatus DecodeFromChars(ReadOnlySpan<char> source, Span<by
//Link: https://learn.microsoft.com/en-us/dotnet/api/system.buffers.text.base64.trydecodefromchars?view=net-11.0
public static bool TryDecodeFromChars(ReadOnlySpan<char> source, Span<byte> destination, out int bytesWritten)
{
try
{
var decoded = DecodeBase64(source);

if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
var decoded = DecodeBase64(source);

decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
catch (FormatException)
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}

decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}

/// <summary>
Expand Down
18 changes: 5 additions & 13 deletions src/Split/net10.0/Base64Polyfill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,23 +136,15 @@ public static OperationStatus DecodeFromChars(ReadOnlySpan<char> source, Span<by
/// </summary>
public static bool TryDecodeFromChars(ReadOnlySpan<char> source, Span<byte> destination, out int bytesWritten)
{
try
{
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
catch (FormatException)
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
/// <summary>
/// Decodes the span of UTF-8 encoded text represented as base-64 into binary data.
Expand Down
18 changes: 5 additions & 13 deletions src/Split/net461/Base64Polyfill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,23 +136,15 @@ public static OperationStatus DecodeFromChars(ReadOnlySpan<char> source, Span<by
/// </summary>
public static bool TryDecodeFromChars(ReadOnlySpan<char> source, Span<byte> destination, out int bytesWritten)
{
try
{
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
catch (FormatException)
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
/// <summary>
/// Decodes the span of UTF-8 encoded text represented as base-64 into binary data.
Expand Down
18 changes: 5 additions & 13 deletions src/Split/net462/Base64Polyfill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,23 +136,15 @@ public static OperationStatus DecodeFromChars(ReadOnlySpan<char> source, Span<by
/// </summary>
public static bool TryDecodeFromChars(ReadOnlySpan<char> source, Span<byte> destination, out int bytesWritten)
{
try
{
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
catch (FormatException)
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
/// <summary>
/// Decodes the span of UTF-8 encoded text represented as base-64 into binary data.
Expand Down
18 changes: 5 additions & 13 deletions src/Split/net47/Base64Polyfill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,23 +136,15 @@ public static OperationStatus DecodeFromChars(ReadOnlySpan<char> source, Span<by
/// </summary>
public static bool TryDecodeFromChars(ReadOnlySpan<char> source, Span<byte> destination, out int bytesWritten)
{
try
{
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
catch (FormatException)
var decoded = DecodeBase64(source);
if (decoded.Length > destination.Length)
{
bytesWritten = 0;
return false;
}
decoded.CopyTo(destination);
bytesWritten = decoded.Length;
return true;
}
/// <summary>
/// Decodes the span of UTF-8 encoded text represented as base-64 into binary data.
Expand Down
Loading
Loading