Board ordering issue (should fix #2710)

[live627]

This is a c&p from getBoardTree() https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/Sources/Subs-Boards.php#L1318

Apparently, this also fixes #2712.

[margarett]

I don't think it fixes #2712 as there is an own query in function MaintainTopics()
I was pretty much asleep when I tested this yesterday but I think that board #1 is lost directly in the first while loop after the query so it didn't even reach Subs-Boards. Although I'm not totally sure anymore 👅

[margarett]

Actually, live, did you test this?
The thing is... #2710 happens in when in a board with child boards. At that time, $boardIndexOptions['include_categories'] is false, which means that smf_categories isn't joined and, as such, your fix causes a "Unknown column 'c.cat_order' in 'order clause'"
So you should drop the c.cat_order from the ORDER BY line 😉

[Emperornero]

I was going to post this earlier, I cannot confirm that this fixes either problem that are referenced in #2712 or #2710.

[live627]

ok thanks for letting me know.