Fixes #3749

[Sesquipedalian]

No description provided.

[frandominguezl]

Again, when entering "Post Event" got 2 errors:

• 1. array_multisort(): Argument Few minor bug fixes #1 is expected to be an array or a sort flag
     Sources/Subs.php
     Line 5035
• 2. Only variables should be passed by reference
     Sources/Subs.php
     Line 5030

No more errors after publishing the Event

[Sesquipedalian]

That's after you changed the following?

Subs.php, line 5030:

		$zones[$tzkey]['locations'][] = str_replace(array('St_', '_'), array('St. ', ' '), array_pop(explode('/', $tzid)));

to

		$tzlocation = array_pop(explode('/', $tzid));
		$zones[$tzkey]['locations'][] = str_replace(array('St_', '_'), array('St. ', ' '), $tzlocation);

I ask because once that change has been made, the array_mulitsort() gets bumped down from line 5035 to line 5036.

[frandominguezl]

Yes

[Sesquipedalian]

But once that change has been made, the error message about array_multisort() should mention line 5036, not line 5035.

[Sesquipedalian]

[frandominguezl]

My bad, I accidentally removed line 5032.

Now the error is in line 5036.

[Sesquipedalian]

Okay, that makes more sense. If line 5032 was missing, then array_multisort would definitely complain, since $offsets would be empty.

[frandominguezl]

Okay, @Sesquipedalian my fault again, I wrote $offset instead of $offsets (heh)

Now that error is gone, but this one is still happening: "Only variables should be passed by reference" Subs.php Line 5030

[frandominguezl]

Done, great job 👍

[Sesquipedalian]

Now that error is gone, but this one is still happening: "Only variables should be passed by reference" Subs.php Line 5030

That's because I moved the entire array_pop(explode('/', $tzid)) when I meant to only move the explode('/', $tzid) part. Should be properly fixed as of the latest commit. :)

EDIT: Ninja'd

[frandominguezl]

Fixed

[frandominguezl]

Alright, just a question. When I enter to Post Event and check the "All Day" box everything is fine, but after clicking "Post", it redirects me to the board where I want to publish the event and the "All Day" box is unchecked. Is this the expected behaviour? Or it should remain checked?

[Sesquipedalian]

That's an oversight. It can probably be fixed fairly easily. Please file a new bug report for it.