[3.0] Theme split (wave 3, part 2) — Rebuild the linktree as a breadcrumb landmark - #9370
Merged
live627 merged 2 commits intoAug 8, 2026
Merged
Conversation
The remaining theme parts are built on two nine-step ramps derived from a single hue each, rather than on individually chosen colours. Adding them ahead of those parts keeps each of them to the tokens it actually introduces. Nothing references the ramps yet and no existing token is repointed at them, so this changes nothing that is rendered. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
The linktree becomes a nav landmark wrapping an ordered list, since the trail is ordered, and carries schema.org BreadcrumbList microdata so a search engine can read it. Layout moves from floats to flexbox, which makes the two rtl.css rules for it redundant. Keeps the HTML entity dividers rather than the icon font used on the theme branch. Nothing in the default theme uses Font Awesome yet, and the bundled local copy has no @font-face rule, so a forum with fontawesome_source set to local would get no divider at all. Keeps emitting the .last class as well, so anything styling it still works, even though :last-child now covers it. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 5, 2026
Closed
live627
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of wave 3 of the #7933 split. Stacked on #9369 — the first commit here is that one, and this diff is the second commit.
Rebuilds the linktree as a proper breadcrumb.
<nav>landmark with an accessible name, wrapping an<ol>rather than a<ul>. The trail is ordered: "General Category" comes before "General Discussion".Because it is flexbox rather than floats, it flips for RTL on its own. That makes the two
rtl.cssrules for it dead, so they go, continuing what parts 7 and 8 of wave 2 started.Two things taken deliberately differently from the theme branch
The dividers stay as HTML entities. The theme branch replaces
►with<i class="fa-solid fa-angle-right">. Nothing in the default theme uses Font Awesome today, and the bundled local copy of it has no@font-facerule at all, so a forum withfontawesome_sourceset tolocalwould get no divider rather than a different one. The same applies to the house icon the branch puts before the trail. Both are easy to add once the local Font Awesome source is fixed, which is worth doing separately..lastis still emitted. The branch drops the class in favour of:last-child, but its own CSS still matches:is(.last, :last-child), and mods and custom themes may well style it. Keeping it costs nothing.Two fixes to what is on the branch
<ul itemscope>and closes</ol>. The stylesheet targetsol, and an ordered list is what a breadcrumb should be, so this opens<ol>.var(--breadcrumb_divider_font_family)with underscores, whilevariables.cssdefines--breadcrumb-divider-font-familywith hyphens. As an undefined token with no fallback it is invalid at computed-value time, so it does not fall back to the previous rule — it unsetsfont-familyon the divider entirely. Spelled correctly here, and confirmed in the browser: the divider computes toArial, sans-serif, which is what tells you it resolved.Verification
Board page in the running forum, computed styles and geometry rather than eyeballing:
nav/ol/aria-label="Breadcrumb"all as intended, 3 crumbs,positionmetas 1 to 3.rgb(42, 66, 85), which ishsl(207, 34%, 25%)— that is--primary-color-800from [3.0] Theme split (wave 3, part 1) — Add the primary and secondary colour ramps #9369 arriving through--breadcrumb-link-color. The current page computes torgb(40, 89, 149)at weight 700.dir="rtl"on the document reverses them to x = 598, 483, 353 with nortl.cssinvolved, which is what shows the two deleted rules really were redundant.index.cssreferences 221 tokens,variables.cssdefines 245, and nothing is referenced without being defined.Issues References (Fixes|Related|Closes)
Related to #7933.