Skip to content

[3.0] Labels pull requests that touch the test suite - #9578

Merged
jdarwood007 merged 1 commit into
SimpleMachines:release-3.0from
albertlast:3.0/labeler-unit-testing
Aug 29, 2026
Merged

[3.0] Labels pull requests that touch the test suite#9578
jdarwood007 merged 1 commit into
SimpleMachines:release-3.0from
albertlast:3.0/labeler-unit-testing

Conversation

@albertlast

Copy link
Copy Markdown
Collaborator

Description

The repository has a Unit Testing label, but .github/labeler.yml had no rule for it, so the Pull Request Labeler job never applied it. A change under tests/ was labelled by whatever production file happened to sit next to it in the same pull request, or not at all.

Five open pull requests touch the suite and none of them carry the label:

PR Test files / total Labels it did get
#9577 1 / 2 Navigation
#9575 1 / 3 Boards, Topics
#9537 2 / 2 Package Manager, Proxy, Backward compatibility
#9347 16 / 22 Installer, Localization
#9345 8 / 14 Installer, Localization

The one merged pull request that does carry Unit Testing, #9511, had it applied by hand.

The rule covers the suite itself plus the two files that decide how it runs:

"Unit Testing":
  - changed-files:
    - any-glob-to-any-file: ['tests/**', 'phpunit.xml.dist', '.github/workflows/phpunit.yml']

Placed alphabetically between Topics and Upgrader, matching the ordering of the rest of the file.

Issues References (Fixes|Related|Closes)

The repository has a Unit Testing label but labeler.yml had no rule for it,
so a change under tests/ was never labelled by the job. Five open pull
requests touch the suite and none of them carry the label; the one merged
pull request that does had it applied by hand.

Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
@jdarwood007 jdarwood007 added the Meta Repository tools label Aug 29, 2026
@jdarwood007 jdarwood007 added this to the 3.0 Alpha 5 milestone Aug 29, 2026
@jdarwood007
jdarwood007 merged commit a600f88 into SimpleMachines:release-3.0 Aug 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Meta Repository tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants