[3.0] Points the dead labeler rules at paths that exist - #9580
Merged
jdarwood007 merged 1 commit intoAug 29, 2026
Merged
Conversation
Eleven globs in labeler.yml named a path that is not in the repository, so the job could never apply those labels. Two rules, Anti-spam and External data, could not fire at all. Also renames the "Login Sessions" rule to "Login/Sessions", which is what the label is actually called; the job cannot apply a label under a name that does not exist. Sources/AntiSpam/ and Sources/ReCaptcha/ have never existed, so the Anti-spam rule now names the admin action that does, plus the captcha script. With this every rule and every glob matches at least one tracked file. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eleven globs in
.github/labeler.ymlnamed a path that is not in the repository, so the Pull Request Labeler job could never apply those labels. Two rules,Anti-spamandExternal data, had no working glob at all and could not fire under any circumstances.AdministrativeTheme/default/Admin.template.phpThemes/default/Admin.template.phpAnti-spamSources/Actions/Admin/Anti-spam.phpSources/Actions/Admin/AntiSpam.phpAnti-spamSources/AntiSpam/**Anti-spamSources/ReCaptcha/**Themes/default/scripts/captcha.jsBoardsThemes/defalt/Board**Themes/default/Board**External dataSources/WebFetch**Sources/WebFetch/**github_actions.github_actions/workflows/**.github/workflows/**MembergroupsSources/Actions/Admin/Membegroups.phpSources/Actions/Admin/Membergroups.phpModerationSources/Moderation**Sources/Actions/Moderation/**RegistrationSources/Actins/Register**Sources/Actions/Register**SmileysSources/ActionAdmin/Smileys.phpSources/Actions/Admin/Smileys.phpSubscriptionsSources/Subscriptions**Sources/Subscriptions/**Two of these are worth a word.
"Login Sessions"is not in the table because it is not a path problem: the rule key was"Login Sessions", while the label in the repository is namedLogin/Sessions. The job cannot apply a label under a name that does not exist, so that rule was dead too. It is renamed to match.Sources/AntiSpam/andSources/ReCaptcha/have never existed in this repository. The only anti-spam code isSources/Actions/Admin/AntiSpam.phpandThemes/default/scripts/captcha.js, so the rule now names those. If those directories are planned, say so and I will put the globs back instead.Three of the fixes are the same trap rather than a typo: in minimatch,
**only crosses a/when it is a whole path segment.Sources/WebFetch**therefore behaves asSources/WebFetch*and matches nothing, becauseWebFetchis a directory;Sources/WebFetch/**matches its seven files. The same applies toSources/Subscriptions**and toSources/Moderation**, whose files live underSources/Actions/Moderation/.How this was checked
Every glob was run against
git ls-fileswith the same matcher the action uses (minimatch,dot: true). Before this change, 2 rules and 11 globs matched no tracked file. After it, every rule and every glob matches at least one.Issues References (Fixes|Related|Closes)