Skip to content

WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor#2776

Merged
greens merged 13 commits into
SmartThingsCommunity:mainfrom
marcintyminski:add-support-to-frient-smoke-co-sensor
Mar 4, 2026
Merged

WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor#2776
greens merged 13 commits into
SmartThingsCommunity:mainfrom
marcintyminski:add-support-to-frient-smoke-co-sensor

Conversation

@marcintyminski

@marcintyminski marcintyminski commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions

github-actions Bot commented Feb 13, 2026

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

   72 files    489 suites   0s ⏱️
2 674 tests 2 674 ✅ 0 💤 0 ❌
4 522 runs  4 522 ✅ 0 💤 0 ❌

Results for commit afeef43.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-carbon-monoxide-detector/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua 93% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against afeef43

@KKlimczukS KKlimczukS requested a review from greens February 27, 2026 11:47
greens
greens reviewed Feb 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/can_handle.lua Outdated
greens
greens reviewed Feb 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
greens
greens reviewed Feb 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
greens
greens reviewed Feb 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
greens
greens reviewed Feb 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
greens
greens reviewed Feb 27, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
@greens greens changed the title Add support to frient smoke co sensor WWSTCERT-10514 Add support to frient smoke co sensor Feb 27, 2026
@greens greens changed the title WWSTCERT-10514 Add support to frient smoke co sensor WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor Feb 27, 2026
greens
greens reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
greens
greens reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-carbon-monoxide-detector/src/frient/init.lua Outdated
@KKlimczukS KKlimczukS requested a review from greens March 3, 2026 10:39
@greens greens merged commit ae55d8f into SmartThingsCommunity:main Mar 4, 2026
12 checks passed
cjswedes pushed a commit that referenced this pull request Mar 25, 2026
@marcintyminski @cjswedes
WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor (#…
dd45164 
…2776)

* initial commit

* handle co value

* complete driver with tests

* removed unused variable

* changes according to pr comments

* pr comments changes
ctowns pushed a commit that referenced this pull request Apr 1, 2026
@marcintyminski @ctowns
WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor (#…
b263df4 
…2776)

* initial commit

* handle co value

* complete driver with tests

* removed unused variable

* changes according to pr comments

* pr comments changes
@ctowns ctowns mentioned this pull request Apr 1, 2026
Merged
JerryYang01 pushed a commit to JerryYang01/SmartThingsEdgeDrivers that referenced this pull request Apr 2, 2026
@marcintyminski @JerryYang01
WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor (S…
a18c412 
…martThingsCommunity#2776)

* initial commit

* handle co value

* complete driver with tests

* removed unused variable

* changes according to pr comments

* pr comments changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wkhenon wkhenon Awaiting requested review from wkhenon
@pegor-karoglanian pegor-karoglanian Awaiting requested review from pegor-karoglanian
1 more reviewer
@greens greens greens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcintyminski @greens