Matter: Update next to __pairs, rawget to __index#2865
Conversation
|
Channel deleted. |
Test Results 72 files 494 suites 0s ⏱️ Results for commit 09c78b1. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 09c78b1 |
db4c9ee to
0361979
Compare
|
Is matter lock the only driver affected by this? The |
0361979 to
3001e44
Compare
|
@ctowns Thank you catching that! not sure what happened, I had updated all 4 drivers. I re-worked that. |
|
Yeah there is something weird going on here, these changes now all have conflicts with the beta branch as well. IDK what happened but I will resolve the conflicts on the beta merge PR |
|
I think you may have done your extra work in the main branch and then locally merged that into this branch ("Merge branch 'main' into update/deep-equals"). So that's why that other commit doesn't show up here. |
Description of Change
In order to support the way that the driver's st_store held data pre-58, we must use the __pairs() and __index() metamethods that are overwritten. Else, the data within the global st_store, when compared, will always compare as equal
Summary of Completed Tests
Unit tests that were failing when run using 0.58 Lua libs now pass with this change. Unit tests run on the latest continue to pass.