Skip to content

remove duplicate code from bad merge#2872

Merged
ctowns merged 1 commit into
mainfrom
fix/remove-bad-code
Apr 1, 2026
Merged

remove duplicate code from bad merge#2872
ctowns merged 1 commit into
mainfrom
fix/remove-bad-code

Conversation

@ctowns

@ctowns ctowns commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

removes duplicate that was accidentally added while addressing merge conflicts between main and beta

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@ctowns ctowns requested a review from hcarter-775 April 1, 2026 18:53
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Test Results

   72 files  ±0    494 suites  ±0   0s ⏱️ ±0s
2 703 tests ±0  2 703 ✅ +16  0 💤 ±0  0 ❌  - 10 
4 575 runs  ±0  4 575 ✅ +19  0 💤 ±0  0 ❌  - 12 

Results for commit 7f5b96c. ± Comparison against base commit b5e30c3.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

File Coverage
All files 85%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/init.lua 82%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_handlers/attribute_handlers.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/bosch_button_contact/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_utils/embedded_cluster_utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_utils/device_configuration.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/smoke_co_alarm/init.lua 82%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_handlers/attribute_handlers.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/legacy_device_configuration.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/device_configuration.lua 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/utils.lua 74%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/fields.lua 92%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7f5b96c

@ctowns ctowns force-pushed the fix/remove-bad-code branch from 63221d9 to 7f5b96c Compare April 1, 2026 19:05
@ctowns ctowns merged commit 3648699 into main Apr 1, 2026
11 checks passed
@ctowns ctowns deleted the fix/remove-bad-code branch April 1, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants