Skip to content

add MultiIR Smoke Detector MIR-SM200#2874

Merged
cbaumler merged 2 commits into
SmartThingsCommunity:mainfrom
thinkaName:multiir_smoke_detector_MIR_SM200
Apr 21, 2026
Merged

add MultiIR Smoke Detector MIR-SM200#2874
cbaumler merged 2 commits into
SmartThingsCommunity:mainfrom
thinkaName:multiir_smoke_detector_MIR_SM200

Conversation

@thinkaName

@thinkaName thinkaName commented Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

   72 files    503 suites   0s ⏱️
2 770 tests 2 770 ✅ 0 💤 0 ❌
4 669 runs  4 669 ✅ 0 💤 0 ❌

Results for commit 7dc18b7.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown

File Coverage
All files 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/frient/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/lazy_load_subdriver.lua 57% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7dc18b7

@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from 0fbd389 to d907021 Compare April 3, 2026 03:38
@cbaumler cbaumler requested review from aleclorimer and cjswedes April 9, 2026 21:12
@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from d907021 to e509e7b Compare April 13, 2026 06:08
aleclorimer
aleclorimer reviewed Apr 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/test/test_multiir_smoke_detector.lua Outdated
}
)

test.run_registered_tests() No newline at end of file

@aleclorimer aleclorimer Apr 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline to EOF

cjswedes
cjswedes reviewed Apr 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/test/test_multiir_smoke_detector.lua Outdated
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/MultiIR/init.lua
Comment on lines +10 to +13
if zone_status:is_alarm1_set() then
device:emit_event(capabilities.smokeDetector.smoke.detected())
elseif zone_status:is_alarm2_set() then
device:emit_event(capabilities.smokeDetector.smoke.tested())

@cjswedes cjswedes Apr 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ZoneStatus attribute bitmap, I see the following in the spec for bits that can be set:

Image

Is the alarm2 bit corresponding to the test functionality just the way the device works? Do we need to also be considering the test mode bit?

@thinkaName thinkaName Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in the capability definition of the smoke detector. It is also required in the Test Suite test items. If this is not added, the test will fail.

@cjswedes cjswedes Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the "tested" variation is a part of the smokeDetector capability, I guess my question is if it is hooked up correctly, since the spec shows a different bit that could be used to indicate it is being tested. Did you validate the test functionality with a real device? Its fine if this is how it works, I just wanted to confirm, since its not how I would expect after reading the spec.

Edit: Sorry, I am a bit new to reviewing WWST PRs. I was able to find the test results you are referencing, and since it passes, LGTM.

@cjswedes

cjswedes commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

All new files are executable, and should be updated to be only read/write

@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from e509e7b to ae4fce4 Compare April 15, 2026 07:24
@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from ae4fce4 to 03dc986 Compare April 15, 2026 09:35
cjswedes
cjswedes approved these changes Apr 20, 2026
View reviewed changes

@cjswedes cjswedes left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleared the artifact cache, and updated the branch to get these tests passing (it was unrelated to these changes). This LGTM.

@cjswedes cjswedes requested a review from cbaumler April 20, 2026 16:03
@cbaumler cbaumler merged commit a9d1692 into SmartThingsCommunity:main Apr 21, 2026
18 of 23 checks passed
aleclorimer pushed a commit that referenced this pull request Apr 29, 2026
@thinkaName @cjswedes @ctowns
add MultiIR Smoke Detector MIR-SM200 (#2874)
973bde8 
Co-authored-by: Carter Swedal <carter.swedal@smartthings.com>
hcarter-775 pushed a commit that referenced this pull request May 6, 2026
@thinkaName @cjswedes @hcarter-775
add MultiIR Smoke Detector MIR-SM200 (#2874)
a4eb3d3 
Co-authored-by: Carter Swedal <carter.swedal@smartthings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes approved these changes
@aleclorimer aleclorimer aleclorimer approved these changes
@cbaumler cbaumler Awaiting requested review from cbaumler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thinkaName @cjswedes @aleclorimer @cbaumler