add MultiIR Water Leak MIR-WA100#2896
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 72 files 505 suites 0s ⏱️ Results for commit bb1d4bd. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against bb1d4bd |
There was a problem hiding this comment.
What is the reason for not including the FW update capability? Even if there are no anticipated FW updates, this will allow us to display the FW version in the devices "Information" section, which is why we have this on all zigbee devices not just those that can have FW updated.
There was a problem hiding this comment.
@cbaumler can you validate this? I am fairly certain it is accurate, but it seems like not all of our zigbee device profiles have the capability
There was a problem hiding this comment.
Yes, that's correct. We should be including the FW update capability for the reasons you stated.
There was a problem hiding this comment.
@thinkaName please add the firmwareUpdate capability to this Profile, and all the other profiles in other PRs you have added.
There was a problem hiding this comment.
Because the product does not have the firmware update function and version information reporting capabilities. If this capability is added to the profile, the test for this capability in the SmartThings Developer Center Test Suite will fail.
5d80678 to
ac9079e
Compare
2f2c40a to
78c6894
Compare
78c6894 to
8711196
Compare
|
@thinkaName please resolve the branch conflicts, and we will merge this PR. Edit: I went ahead and resolved the conflict and merged. |
Co-authored-by: Chris Baumler <chris.baumler@smartthings.com>
Co-authored-by: Chris Baumler <chris.baumler@smartthings.com>
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests