Skip to content

add MultiIR Water Leak MIR-WA100#2896

Merged
cbaumler merged 2 commits into
SmartThingsCommunity:mainfrom
thinkaName:multiir_water_leak_MIR-WA100
Apr 21, 2026
Merged

add MultiIR Water Leak MIR-WA100#2896
cbaumler merged 2 commits into
SmartThingsCommunity:mainfrom
thinkaName:multiir_water_leak_MIR-WA100

Conversation

@thinkaName

@thinkaName thinkaName commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

Test Results

   72 files    505 suites   0s ⏱️
2 777 tests 2 777 ✅ 0 💤 0 ❌
4 678 runs  4 678 ✅ 0 💤 0 ❌

Results for commit bb1d4bd.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-water-leak-sensor/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-water-leak-sensor/src/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-water-leak-sensor/src/frient/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against bb1d4bd

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for not including the FW update capability? Even if there are no anticipated FW updates, this will allow us to display the FW version in the devices "Information" section, which is why we have this on all zigbee devices not just those that can have FW updated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbaumler can you validate this? I am fairly certain it is accurate, but it seems like not all of our zigbee device profiles have the capability

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. We should be including the FW update capability for the reasons you stated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkaName please add the firmwareUpdate capability to this Profile, and all the other profiles in other PRs you have added.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the product does not have the firmware update function and version information reporting capabilities. If this capability is added to the profile, the test for this capability in the SmartThings Developer Center Test Suite will fail.

@thinkaName thinkaName force-pushed the multiir_water_leak_MIR-WA100 branch from 5d80678 to ac9079e Compare April 15, 2026 09:13
Comment thread drivers/SmartThings/zigbee-water-leak-sensor/fingerprints.yml Outdated
@thinkaName thinkaName force-pushed the multiir_water_leak_MIR-WA100 branch from 2f2c40a to 78c6894 Compare April 21, 2026 06:21
@thinkaName thinkaName force-pushed the multiir_water_leak_MIR-WA100 branch from 78c6894 to 8711196 Compare April 21, 2026 06:25
@cbaumler

cbaumler commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@thinkaName please resolve the branch conflicts, and we will merge this PR.

Edit: I went ahead and resolved the conflict and merged.

@cbaumler cbaumler merged commit f865fd9 into SmartThingsCommunity:main Apr 21, 2026
14 of 17 checks passed
aleclorimer pushed a commit that referenced this pull request Apr 29, 2026
Co-authored-by: Chris Baumler <chris.baumler@smartthings.com>
hcarter-775 pushed a commit that referenced this pull request May 6, 2026
Co-authored-by: Chris Baumler <chris.baumler@smartthings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants