SONARJAVA-6764 Implement cache for BeanDefinitionGatherer

[NoemieBenard]

---

Summary by Gitar

• Caching:
  • Implemented caching mechanism for BeanDefinitionGatherer in BeanDefinitionGatherer.java
  • Added comprehensive unit tests covering cache hits, misses, serialization, and error handling

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-6764

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
98.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[asya-vorobeva]

👍

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Implements a caching mechanism for BeanDefinitionGatherer along with comprehensive unit tests. The potential unhealable corrupted cache entry issue was successfully addressed.

✅ 1 resolved

✅ Bug: Corrupted cache entry never self-heals after re-parse

📄 java-frontend/src/main/java/org/sonar/java/model/springcontext/BeanDefinitionGatherer.java:199-212 📄 java-frontend/src/main/java/org/sonar/java/model/springcontext/BeanDefinitionGatherer.java:144-155 📄 java-frontend/src/main/java/org/sonar/java/model/springcontext/BeanDefinitionGatherer.java:186-190
In readFromCache, copyFromPrevious(cacheKey) is called (line 199) before deserialization. When deserialization fails (corrupt entry, or a future serialization-format change), the catch returns Optional.empty() so scanWithoutParsing returns false and the file is re-parsed. But copyFromPrevious has already registered the (stale/corrupt) entry under cacheKey in the write cache, so leaveFile's writeToCache call hits the duplicate-key IllegalArgumentException and is silently swallowed. The freshly parsed data is discarded and the corrupt entry is carried forward on every subsequent incremental analysis, so it never recovers — and on a format change this affects all files at once, permanently serving stale bean definitions. Move copyFromPrevious to only run after successful deserialization (or skip it on the failure path) so re-parsed files can rewrite their cache entry.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}