Fix template deduction for windows compilation - #449
Merged
Merged
Conversation
Vauff
added a commit
that referenced
this pull request
Sep 9, 2026
* Switch to Metamod KHook development branch * fix includes, some definitely wrong messing around with api * first khook theoretically working * Finish migration of main virtual hooks Still needs testing * fix building docker container * fix build errors * fix more build errors * update khook include path * Fix VTable hooks * Migrate EntWatch virtual hooks * various fixes & remove/add some todo's * more fixes * "fix" another calloriginal * Fix EntWatch crashes * Re-enable GoToIntermission hook Seems to have stopped crashing? * Fix PostEventAbstract crash * Migrate detour system to KHook * fix TakeDamage crash * Fix template deduction for windows compilation (#449) * Fix template deduction * alternative workaround: explicitly define template arguments --------- Co-authored-by: Kenzzer <kenzzer@users.noreply.github.com> Co-authored-by: Vauff <mctehkitti@gmail.com> * fix bad copy paste * Replace our signature lookup with KHook's implementation This allows for signature lookups to always work even on signatures modified by another plugins KHook detour * switch back to metamod master branch * Remove wildcard converter now that KHook supports singles * Address automatic review findings --------- Co-authored-by: Benoist <14257866+Kenzzer@users.noreply.github.com> Co-authored-by: Kenzzer <kenzzer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.