Skip to content

Add matrix_opt for cuSPARSE backend#66

Open
tdehoff wants to merge 6 commits into
SparseBLAS:mainfrom
tdehoff:main
Open

Add matrix_opt for cuSPARSE backend#66
tdehoff wants to merge 6 commits into
SparseBLAS:mainfrom
tdehoff:main

Conversation

@tdehoff

@tdehoff tdehoff commented Mar 25, 2026

Copy link
Copy Markdown

Summary:
Adds the following for the cuSPARSE backend: matrix_handle for CSR and CSC formats, SpMM, small updates to SpMV, draft of SpGEMM.

Details:

Since I wasn't able to test SpGEMM, I expect it to have multiple issues.
A simple case of SpMM was verified in the example file.

Merge Checklist:

  • Passing CI
  • Update documentation or README.md
  • Additional Test/example added (if applicable) and passing
  • At least one reviewer approval
  • (optional) Clang sanitizer scan run and triaged
  • Clang formatter applied (verified as part of passing CI)

@yhmtsai yhmtsai self-requested a review April 9, 2026 17:09

@yhmtsai yhmtsai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tdehoff
Excellent work! I have some nit which needs to address.
When it is possible, we would like to have a small pr rather than large pr.
Thus, I will suggest to remove the spgemm part out of this pr because it is not finished and can be in another pr like #54

Comment thread include/spblas/vendor/cusparse/detail/create_matrix_handle.hpp Outdated
Comment thread include/spblas/vendor/cusparse/detail/create_matrix_handle.hpp Outdated
Comment thread include/spblas/vendor/cusparse/detail/get_matrix_handle.hpp Outdated
Comment thread include/spblas/vendor/cusparse/spmv_impl.hpp
Comment thread include/spblas/views/matrix_opt_impl.hpp Outdated
@tdehoff

tdehoff commented May 15, 2026

Copy link
Copy Markdown
Author

Hi @yhmtsai!
Thank you for the feedback. I renamed all instances of matrix_handle to matrix_descriptor, removed the unused b_descr and c_descr, and removed spgemm from the PR.
Let me know if there's anything else I missed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants