Skip to content

Modernize project structure and build system - #119

Merged
brunoenten merged 40 commits into
masterfrom
feat/modernize
May 21, 2023
Merged

Modernize project structure and build system#119
brunoenten merged 40 commits into
masterfrom
feat/modernize

Conversation

@SpotlightKid

@SpotlightKid SpotlightKid commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner
  • docs: convert readme, changelog, authors, and install docs to Markdown
  • feat: generate dev requirements via pip-tools
  • feat: switch to meson / mesonpep517 build system
  • feat: remove travis and Appveyor CI setup
  • feat: add GitHub Actions workflow to build wheels with cibuildwheel

@SpotlightKid SpotlightKid self-assigned this Dec 12, 2022
@SpotlightKid
SpotlightKid force-pushed the feat/modernize branch 2 times, most recently from 4e58c4d to 4368c66 Compare December 13, 2022 00:16
@SpotlightKid
docs: convert readme, changelog, authors, and install docs to Markdown
01afb1c 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
eli-schwartz
eli-schwartz suggested changes Dec 13, 2022
View reviewed changes
Comment thread meson.build Outdated
Comment thread meson.build Outdated
Comment thread meson.build Outdated
Comment thread meson.build Outdated
@SpotlightKid
SpotlightKid marked this pull request as draft December 13, 2022 13:39
@SpotlightKid
SpotlightKid force-pushed the feat/modernize branch 2 times, most recently from 3dcd639 to e192f36 Compare December 13, 2022 22:24
@SpotlightKid
feat: generate dev requirements via pip-tools
81fdac2 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: switch to meson / mesonpep517 build system
1fa98c3 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
docs: update install instructions
b82abd8 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: remove travis and Appveyor CI setup
eea2603 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: version restrictions for JACK 1 dependency
16609dc 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: remove uneeded stuff from meson build files and correct comments
310c92b 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: use 'host_machine' instead of 'target_machine' in meson build files
0378b2f 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: meson dependency checks
6bc8478 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: run meson install and dist scripts with correct Python version
d816644 
Also respect --quiet option in these scripts

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: handle neither JACK 1 nor JACK 2 dependency found
1857bcc 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: add GitHub Actions workflow to build wheels with cibuildwheel
7a6e363 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: add cibuildwheel config to pyproject.toml
a443563 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: workflow step 'upload_pypi' also depends on step 'build_arch_whe…
f52c649 
…els'

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: update GitHub Actions versions
ebde2fb 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: GH actions: set python version to 3.11 and macos to latest
ecc1594 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: limit windows builds to amd64 arch
edc36f4 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: provisional workaround for failing check for winmm
b694d19 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
docs: convert readme, changelog, authors, and install docs to Markdown
513025c 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: generate dev requirements via pip-tools
348a8f5 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: switch to meson / mesonpep517 build system
3b715eb 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
docs: update install instructions
23ba24d 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: remove travis and Appveyor CI setup
6a7fb46 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: version restrictions for JACK 1 dependency
e506967 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: remove uneeded stuff from meson build files and correct comments
a79b1bc 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: use 'host_machine' instead of 'target_machine' in meson build files
97b77c5 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: meson dependency checks
e60fb72 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: run meson install and dist scripts with correct Python version
7e77f5b 
Also respect --quiet option in these scripts

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: handle neither JACK 1 nor JACK 2 dependency found
9cc3e2e 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: add GitHub Actions workflow to build wheels with cibuildwheel
cbf31ed 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
feat: add cibuildwheel config to pyproject.toml
a438b5d 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: workflow step 'upload_pypi' also depends on step 'build_arch_whe…
e0d7775 
…els'

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: update GitHub Actions versions
bd843a8 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: GH actions: set python version to 3.11 and macos to latest
4972e80 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: limit windows builds to amd64 arch
12fb0db 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@SpotlightKid
fix: provisional workaround for failing check for winmm
c8676c1 
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
Czaki
Czaki reviewed Apr 11, 2023
View reviewed changes

@Czaki Czaki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like error is here:

c++.exe: error: unrecognized command-line option '-framework'

But the only place when I see passing this flag to the compilator is Macos builds.

Comment thread .github/workflows/publish-to-test-pypi.yml
@brunoenten brunoenten mentioned this pull request May 21, 2023
Closed
@brunoenten
brunoenten marked this pull request as ready for review May 21, 2023 08:09
@brunoenten
brunoenten merged commit 8b91fb1 into master May 21, 2023
@brunoenten
brunoenten deleted the feat/modernize branch May 21, 2023 08:12
This was referenced May 21, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Czaki Czaki Czaki left review comments
@eli-schwartz eli-schwartz eli-schwartz requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@SpotlightKid SpotlightKid

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SpotlightKid @mikacousin @Czaki @eli-schwartz @brunoenten