Skip to content

Streams Transaction Issue #2167

Closed
Closed

Description

@askoutaris

All methods inside RedisDatabase.cs which call ExecuteAsync with parameter 'T defaultValue' (eg StreamReadGroupAsync) does not work with transactions since there is no override ExecuteAsync with parameter 'T defaultValue' in RedisTransaction.cs and as a result ExecuteAsync of RedisBase.cs is used instead of RedisTransaction.cs

FYI: I downloaded the code and managed it to work by adding the overriden methods shown in the attached screenshot.

2022-06-21 17_49_48-RedisStreams - Microsoft Visual Studio Preview

Activity

  1. mgravell commented on Jun 21, 2022

    @mgravell
    Collaborator

    agreed, this looks like a problem; do you have any concrete examples of failure cases here? honestly, the best thing is probably to submit this as a PR including tests

  2. askoutaris commented on Jun 22, 2022

    @askoutaris
    Author

    Thank you for your feedback!
    I'll try to find some time in the next days to study and follow all Github's procedures about branching and PR policies in order to help you with that.

  3. added a commit that references this issue on Jun 28, 2022
    b585710
  4. added a commit that references this issue on Jan 27, 2024
    0ebe530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions