You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All methods inside RedisDatabase.cs which call ExecuteAsync with parameter 'T defaultValue' (eg StreamReadGroupAsync) does not work with transactions since there is no override ExecuteAsync with parameter 'T defaultValue' in RedisTransaction.cs and as a result ExecuteAsync of RedisBase.cs is used instead of RedisTransaction.cs
FYI: I downloaded the code and managed it to work by adding the overriden methods shown in the attached screenshot.
agreed, this looks like a problem; do you have any concrete examples of failure cases here? honestly, the best thing is probably to submit this as a PR including tests
Thank you for your feedback!
I'll try to find some time in the next days to study and follow all Github's procedures about branching and PR policies in order to help you with that.
Activity
mgravell commentedon Jun 21, 2022
agreed, this looks like a problem; do you have any concrete examples of failure cases here? honestly, the best thing is probably to submit this as a PR including tests
askoutaris commentedon Jun 22, 2022
Thank you for your feedback!
I'll try to find some time in the next days to study and follow all Github's procedures about branching and PR policies in order to help you with that.
Batch/Transaction need to override new ExecuteAsync API; fix #2167 fix …
URGENT Fix error in batch/transaction handling (StackExchange#2177)