Repository navigation
feat(admission): preserve rate state across runtime updates (#333) - #334
Conversation
SunSi12138
left a comment
There was a problem hiding this comment.
Re-reviewed exact head 5856422666373ae596ce4920c7b7159d98d199bc. The two prior P1s are addressed by the tests-first fixes, and exact-head PR Quick 32846203932 is green. One remaining P1 exists in the structural-replacement TokenBucket carry model: carried transition debt and target-owned token debt currently consume the same elapsed replenishment time independently, so a barrier expiry can still expose quota that the target's intervening grants already consumed.
SunSi12138
left a comment
There was a problem hiding this comment.
Re-reviewed exact head 46c1285d25b8445d26d050256e8ad590859b541b against #333. The third P1 is fixed: TokenBucket carry and target-owned debt now share one replenishment-credit ledger, the deterministic target-traffic regression covers the previous double-spend counterexample, and the two earlier P1 fixes remain intact. I did not find any remaining P1/P2 in the reviewed slice. Exact-head PR Quick 32866292921 is green across all gates. Clean at this head.
Implements #333.
Scope
This PR is now restacked directly on
devafter #332 landed.dev@7472542155f440837740e7ee4061abf91981b1dd33eaf66147509bb508f51a2b5200f9216a7b1354Implementation
Restack compatibility
The direct-to-
devrestack preserves already-landed #332 semantics while retaining #333's rate-state model:SharpLinkAdmissionContextboundary;AdmissionPartitionEntryowner/exact-once release/idle-reclaim semantics;_timeProvider-aware rate runtime creation;Review fixes
All three historical P1 review threads are resolved:
Exact-head validation
Exact head:
33eaf66147509bb508f51a2b5200f9216a7b1354.33031925362: completed / success.33031925214: completed / success.33031925202: completed / success.18,280.34 QPS, c=474,523.24 QPS, 0 failures.770267successes,164464injected faults,0unexpected,0client/server errors,0unobserved; retained memory1498968 -> 1055080(-29.61%).10.0.110vs verifier10.0.111; its 40/40 safe fixtures had 0 blocking failures. Rerunning failed jobs regenerated consistent evidence and the full PR Quick workflow completed successfully.Ready to merge.