Repository navigation
refactor(client): retire readiness state transition test shim (#801) - #833
Merged
SunSi12138 merged 1 commit intoOct 11, 2026
Merged
Conversation
4 of 13 tasks
SunSi12138
added a commit
that referenced
this pull request
Oct 11, 2026
Rebase #833 onto latest dev and retain readiness regression coverage.
SunSi12138
force-pushed
the
cleanup/issue-801-client-readiness-transition-shim
branch
from
October 11, 2026 10:16
aed1206 to
bad9a57
Compare
SunSi12138
marked this pull request as ready for review
October 11, 2026 10:20
SunSi12138
force-pushed
the
cleanup/issue-801-client-readiness-transition-shim
branch
from
October 11, 2026 11:48
bad9a57 to
bd3d783
Compare
Owner
Author
|
已按 review 建议将 #833 重新变基到最新
PR 未合并。 |
SunSi12138
deleted the
cleanup/issue-801-client-readiness-transition-shim
branch
October 11, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #801.
Scope (unchanged after rebase)
SharpLinkClient.TransitionToForTesting(SharpLinkConnectionState)forwarding method.SharpLinkClient.TransitionTo(SharpLinkConnectionState)visibility fromprivatetointernal. Keep the complete state machine,NormalizeAvailabilityState, publication, locking, stop guard and runtime callers unchanged.SharpLinkClientReadinessStateTeststoclient.TransitionTo(...), preserving the existing readiness race/state assertions.Post-#827 rebase / conflict resolution
dev@965e25d542eaf4d35b234fe028f74c2b3eaf8be7, including merged #827.bd3d7839c100bce656fcbb9500ba51c7a3a41df1, clean single commit parented directly on the currentdev; the old refactor(client): retire readiness state transition test shim (#801) #833 head was replaced.SharpLinkClient.csnorClientAssemblyRegistry.cscontainsGetShutdownDependencyOrder. In particular, the new head does not restore the formerSharpLinkClient.GetShutdownDependencyOrderforwarding method.SharpLinkClient.Readiness.cs,SharpLinkClient.csandSharpLinkClientReadinessStateTests.cs(+11/-14). No changes toClientAssemblyRegistry.csor unrelated areas.mergeable: truefor this exact head.CI / merge gate
An entirely new PR Fast, Package Smoke, allocation, C# analysis and targeted regression check set was automatically triggered for
bd3d7839c100bce656fcbb9500ba51c7a3a41df1. Prior CI from old heads is not counted. Review the exact-head GitHub check results before merging; neither this rebase nor the preliminary mergeability check constitutes CI passage.