Rebrand the bundle from Fp to Svaroh - #1
Merged
Merged
Conversation
66Ton99
force-pushed
the
rebrand/svaroh-2.0
branch
3 times, most recently
from
August 21, 2026 14:38
4c6f07a to
5f56507
Compare
66Ton99
changed the title
This repository is a new home for the bundle, maintained by Svaroh. formapro/JsFormValidatorBundle keeps the fp/jsformvalidator-bundle package. svaroh/jsformvalidator-bundle is a new Composer package versioned from 1.0. It does not continue the fp/jsformvalidator-bundle version numbers and is not a 2.0 of it, so the master branch alias is 1.0-dev. Renames every public identifier from Fp/fp to Svaroh/svaroh: - Composer package fp/jsformvalidator-bundle -> svaroh/jsformvalidator-bundle - PHP namespace Fp\JsFormValidatorBundle -> Svaroh\JsFormValidatorBundle - Bundle class FpJsFormValidatorBundle -> SvarohJsFormValidatorBundle - DI extension, alias, service ids and parameters fp_js_form_validator.* -> svaroh_js_form_validator.* - Route name fp_js_form_validator.check_unique_entity -> svaroh_js_form_validator.check_unique_entity - Published asset directory bundles/fpjsformvalidator -> bundles/svarohjsformvalidator - JavaScript globals FpJs* -> SvarohJs*, including the UniqueEntity constraint global, which is derived from the PHP FQCN - JavaScript files FpJsFormValidator.js, FpJsFormValidatorWithJqueryInit.js and jquery.fpjsformvalidator.js -> Svaroh* equivalents Behaviour is unchanged. The Twig functions init_js_validation() and js_validator_config(), the jQuery plugin method jsFormValidator(), the js_validation option, and the rendered DOM markup all keep their names. Applications switching from fp/jsformvalidator-bundle must rename the package, bundle class, config key, route import, service references, JavaScript imports and globals. The MIT notice keeps the original Forma-Pro copyright line and adds Svaroh. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
66Ton99
force-pushed
the
rebrand/svaroh-2.0
branch
from
August 21, 2026 14:41
5f56507 to
7e8656b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes this repository a new home for the bundle and renames every public
Fp/fpidentifier toSvaroh/svaroh.svaroh/jsformvalidator-bundleis a new Composer package versioned from1.0. It is not a2.0offp/jsformvalidator-bundleand does not continueits version numbers, so the master branch alias is
1.0-dev.formapro/JsFormValidatorBundlekeeps thefp/jsformvalidator-bundlepackage.A companion PR there announces the move.
What Was Renamed
fp/jsformvalidator-bundlesvaroh/jsformvalidator-bundleFp\JsFormValidatorBundleSvaroh\JsFormValidatorBundleFpJsFormValidatorBundleSvarohJsFormValidatorBundlefp_js_form_validatorsvaroh_js_form_validatorfp_js_form_validator.*svaroh_js_form_validator.*fp_js_form_validator.check_unique_entitysvaroh_js_form_validator.check_unique_entitybundles/fpjsformvalidator/bundles/svarohjsformvalidator/FpJs*SvarohJs*FpJsFormValidator.js,FpJsFormValidatorWithJqueryInit.js,jquery.fpjsformvalidator.jsSvaroh*equivalentsThe
UniqueEntityJavaScript global changes as a consequence of the namespacerename, because globals are resolved by stripping backslashes from the PHP
FQCN. Custom
App\...constraints and transformers are unaffected.What Did Not Change
Behaviour is identical. These keep their names, so applications do not have to
touch them:
init_js_validation()andjs_validator_config()$(form).jsFormValidator(...)js_validationform option and its per-form/per-field behaviourDocs
README.mdexplains the split between this repository and formapro, statesthat versioning starts fresh at
1.0, and points existing users atfp/jsformvalidator-bundle:^1.8.composer.jsonanddocker-compose.ymlset the dev version to1.0-devinstead of the inherited
2.0-dev.AGENTS.mdkeeps the pre-move history attributed toformapro/master.Licensing
LICENSEkeeps the originalCopyright (C) 2014 by Forma-Proline and addsCopyright (C) 2026 by Svaroh. The original copyright holder is not removed.Verification
Run locally in the Nix dev shell (PHP 8.5.6, Node 24.16.0):
composer validate --strict— validcomposer test— 27 tests, 92 assertions, OKcomposer phpstan— no errors, including a successful Symfony test-containerwarmup with the new bundle class and DI alias
npx jest— 31 suites, 233 tests passed🤖 Generated with Claude Code