feat(cli, service): support for project image - #3623
Merged
Conversation
mohammad-alisafaee
force-pushed
the
3576-project-icon
branch
from
September 27, 2023 06:33
048e739 to
918fbd3
Compare
Collaborator
Pull Request Test Coverage Report for Build 6407729967
💛 - Coveralls |
mohammad-alisafaee
force-pushed
the
3576-project-icon
branch
2 times, most recently
from
October 1, 2023 15:59
a6e5a0b to
8c3c6ab
Compare
mohammad-alisafaee
force-pushed
the
3576-project-icon
branch
6 times, most recently
from
October 2, 2023 13:26
5b56deb to
aacc3e5
Compare
mohammad-alisafaee
force-pushed
the
3576-project-icon
branch
from
October 2, 2023 14:14
aacc3e5 to
ca197a8
Compare
mohammad-alisafaee
force-pushed
the
3576-project-icon
branch
from
October 2, 2023 14:18
ca197a8 to
504d6cd
Compare
mohammad-alisafaee
marked this pull request as ready for review
October 2, 2023 15:10
Panaetius
previously approved these changes
Oct 3, 2023
Panaetius
left a comment
Member
There was a problem hiding this comment.
looks great, tiny suggestion, feel free to ignore
Panaetius
approved these changes
Oct 4, 2023
mohammad-alisafaee
enabled auto-merge (squash)
October 4, 2023 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
-iand--imageflags toinitandproject editcommands that accepts a path/URL to an image. The image is copied to.renku/images/project/0.pngand added to the project.NOTE
Fixes #3576