Skip to content

fix(service): allow setting keywords on project creation - #3665

Merged
Panaetius merged 3 commits into
developfrom
fix/3618-create-project-keywords
Jan 4, 2024
Merged

fix(service): allow setting keywords on project creation#3665
Panaetius merged 3 commits into
developfrom
fix/3618-create-project-keywords

Conversation

@Panaetius

Copy link
Copy Markdown
Member

closes #3618

@Panaetius
Panaetius requested a review from a team as a code owner December 7, 2023 14:00
@coveralls

coveralls commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 7413798667

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.432%

Totals Coverage Status
Change from base Build 7407168194: 0.02%
Covered Lines: 26424
Relevant Lines: 30930

💛 - Coveralls

@mohammad-alisafaee mohammad-alisafaee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius
Panaetius enabled auto-merge (squash) December 20, 2023 16:33
@Panaetius
Panaetius merged commit 9377ac4 into develop Jan 4, 2024
@Panaetius
Panaetius deleted the fix/3618-create-project-keywords branch January 4, 2024 19:39
Panaetius pushed a commit that referenced this pull request Jan 15, 2024
* chore(service): return cli version in core svc (#3655)

* fix(cli): use lower case image names for sessions in upper-case projects (#3666)

* fix(service): add proper error if a dataset can't be found (#3661)

* fix: prevent distutils warning (#3663)

* fix(service): allow editing datasets without creator email (#3664)

* fix(cli): output proper session link and only check registry if logged in (#3660)

* fix(service): allow setting keywords on project creation (#3665)

* chore: combined dependency update (#3672)

bump dependencies, fix gitpython security advisory

* feat(service): date_published in datasets.list response (#3648)

* fix(service): fix clone depth not being respected (#3678)

* chore: release v2.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Passed-in keywords argument aren't used in templates.create_project

3 participants