Skip to content

chore: selenium tests to install CLI version fetched from core - #3379

Closed
jachro wants to merge 4 commits into
masterfrom
selenium-tests-to-read-cli-version-from-core
Closed

chore: selenium tests to install CLI version fetched from core#3379
jachro wants to merge 4 commits into
masterfrom
selenium-tests-to-read-cli-version-from-core

Conversation

@jachro

@jachro jachro commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

This PR changes the behaviour of selenium tests in a way that they call the /api/renku/apiversion API and read the new cli_version property. This way the tests will always use CLI that is compatible (in fact the same) as installed on renku-core.

NOTICE:

      {{ if .Values.global.renku.cli_version }}
      - name: RENKU_CLI_VERSION
        value: '{{ .Values.global.renku.cli_version }}'
      {{ end }}

/deploy

@jachro
jachro requested a review from a team as a code owner November 21, 2023 14:37
@RenkuBot

Copy link
Copy Markdown
Collaborator

You can access the deployment of this PR at https://ci-renku-3379.dev.renku.ch

@rokroskar

Copy link
Copy Markdown
Member

@jachro @Panaetius we should be able to merge this?

@jachro

jachro commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

@jachro @Panaetius we should be able to merge this?

A good question. I updated the PR and took out the link to renku-python branch. Let's see.

@jachro

jachro commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

The selenium mtests run and failed as the response from https://ci-renku-3379.dev.renku.ch/api/renku/apiversion

{"result":{"maximum_api_version":"2.2","latest_version":"2.9.1","supported_project_version":10,"minimum_api_version":"1.0"}}

didn't contain the expected cli_version property. @Panaetius was that change adding the property part of the lastest release on renku-python?

@rokroskar

Copy link
Copy Markdown
Member

@Panaetius I guess we can close this?

@olevski olevski closed this Apr 9, 2025
@github-project-automation github-project-automation Bot moved this from Observed to Done in KG's kanban Apr 9, 2025
@RenkuBot

RenkuBot commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants