chore: selenium tests to install CLI version fetched from core - #3379
Closed
jachro wants to merge 4 commits into
Closed
chore: selenium tests to install CLI version fetched from core#3379jachro wants to merge 4 commits into
jachro wants to merge 4 commits into
Conversation
Collaborator
|
You can access the deployment of this PR at https://ci-renku-3379.dev.renku.ch |
Member
|
@jachro @Panaetius we should be able to merge this? |
Contributor
Author
A good question. I updated the PR and took out the link to renku-python branch. Let's see. |
Contributor
Author
|
The selenium mtests run and failed as the response from https://ci-renku-3379.dev.renku.ch/api/renku/apiversion didn't contain the expected |
Member
|
@Panaetius I guess we can close this? |
Collaborator
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of selenium tests in a way that they call the
/api/renku/apiversionAPI and read the newcli_versionproperty. This way the tests will always use CLI that is compatible (in fact the same) as installed on renku-core.NOTICE:
helm-chart/renku/templates/tests/test-renku.yaml; it cannot be done now as it will be brought with Update from auto-update/renku-graph-2.47.1 #3370./deploy