Repository navigation
The release note that documents a green deploy is what turned main red - #1018
Merged
Merged
Conversation
`2026-08-09-check-a-deployment-is-current.md` shipped with `Category: What's New` and no `Order`. `WhatsNewEntryIntegrityTest` requires `Feature` or `Fix` and an `Order` of the negative ship date, so main went red the moment #1006 merged — the entry never ran against the test until it was already on main. The entry is now `Category: Feature`, `Order: -20260809`, matching its five siblings from today. The generator was the pullrequest skill contradicting itself. Its procedure block was updated for the new contract, but the prose section further down still described `Category: What's New` with no `Order` at all — and that is the half a reader quotes when writing an entry by hand. Both halves now say the same thing, and the prose names the consequence: a wrong Category or a missing Order reds MAIN rather than the PR, because a What's New entry only meets the test after it has merged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a documentation integrity regression that turned main red after merge by bringing a WhatsNew release note’s frontmatter back into compliance with WhatsNewEntryIntegrityTest and by updating the pullrequest skill text so future entries follow the same enforced contract.
Changes:
- Update the 2026-08-09 WhatsNew entry frontmatter to use
Category: Featureand addOrder: -20260809. - Align the
pullrequestskill’s prose guidance with the enforced frontmatter contract (Category∈ {Feature, Fix} and requiredOrder).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/MeshWeaver.Documentation/Data/WhatsNew/2026-08-09-check-a-deployment-is-current.md |
Fixes release note frontmatter so the WhatsNew feed and integrity test expectations match. |
.claude/skills/pullrequest/SKILL.md |
Updates authoring guidance to match the test-enforced WhatsNew frontmatter contract and documents the “main turns red after merge” failure mode. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red at
fd277b36fonWhatsNewEntryIntegrityTest.EveryEntry_CarriesTheFrontmatterTheFeedRendersFrom(shard 4). This is the fix.What happened
2026-08-09-check-a-deployment-is-current.md, the release note for #956, shipped withCategory: What's Newand noOrder. The integrity test requiresCategoryto beFeatureorFix, andOrderto be the negative ship date (-20260809) — without which the doc tree sorts the entry alphabetically by title instead of newest-first.The timing is the whole point: a What's New entry does not meet this test until it has already merged. The PR that adds one is green, and
maingoes red on the merge commit. So this failure mode always lands on main, never on the PR that caused it.The entry now matches its five siblings from today.
The generator, not just the instance
The
pullrequestskill contradicted itself. Its procedure block (step 0.5) had been updated for the current contract —Category: <Feature|Fix>,Order: -${DATE//-/}. Its prose section further down still said:No
Orderat all, and aCategoryvalue the test rejects outright. That is the half a reader quotes when hand-writing an entry, which is exactly how this one was written.Both halves now state the same contract, and the prose names the consequence — a wrong
Categoryor a missingOrderreds main, not your PR. Fixing only the entry would have left the next author with the same instructions that produced it.Verification
Frontmatter now reads
Category: Feature/Order: -20260809, matching2026-08-09-write-conflicts-merge-not-vanish.mdand the other four entries from today that pass. Two files, no code.🤖 Generated with Claude Code