Repository navigation
A MenuItemControl silently ignored WithClass #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0a75bc1
A MenuItemControl silently ignored WithClass
rbuergi ea6cb2a
Merge remote-tracking branch 'origin/main' into fix/menuitem-honours-…
rbuergi 19f7865
What's New entry: add the required Order field
rbuergi c7605ad
Merge remote-tracking branch 'origin/main' into fix/menuitem-honours-…
rbuergi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...eaver.Documentation/Data/WhatsNew/2026-08-09-menu-buttons-keep-their-styling.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| Name: Dropdown buttons keep the styling they were given | ||
| Category: Fix | ||
| Description: A button with a dropdown now honours the appearance its page asked for, instead of quietly falling back to the default look. | ||
| Icon: Sparkle | ||
| Order: -20260809 | ||
| --- | ||
|
|
||
| # Dropdown buttons keep the styling they were given | ||
|
|
||
| A button that carries a dropdown menu ignored the styling its page had asked for and always | ||
| rendered in the default look. On pages that style their buttons deliberately — a product page whose | ||
| call to action uses the page's own colours, for instance — this showed up as one button suddenly | ||
| looking unlike the others next to it, and changing appearance depending on what state the page was | ||
| in. | ||
|
|
||
| Those buttons now look the way the page intended, in every one of their forms: with a dropdown | ||
| alone, with a main action plus a dropdown, and as a plain entry inside an open menu. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.