Repository navigation
fix(build): chain memex/Directory.Build.props to root (CI versioning + warnings gate) - #117
Conversation
…rsioning + warnings gate) memex/Directory.Build.props was a bare <Project> that didn't import the root, and MSBuild auto-imports only the NEAREST Directory.Build.props. So nothing under memex/ — the portal + migration images especially — got the root's CI versioning, security package overrides, or TreatWarningsAsErrors. The images were tagged the SDK-default 1.0.0 instead of $(PlatformVersion)-ci.$(GITHUB_RUN_NUMBER), so the self-updater's continuous channel never saw a newer build (everything was "1.0.0"). - Import the root (GetPathOfFileAbove). Verified: CI version now computes 3.0.0-ci.<run>, release 3.0.0. - Chaining also turns on TreatWarningsAsErrors for memex/ (it had silently escaped the repo's warnings-as-errors gate), surfacing 12 latent doc-comment issues — fixed: 8 unresolvable/ ambiguous crefs in Memex.Portal.Shared, 1 malformed-XML summary + 3 cross-assembly crefs in Database.Migration. memex/ now builds clean under the gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Test Results (shard 2) 12 files ±0 12 suites ±0 7m 3s ⏱️ + 2m 37s For more details on these failures, see this check. Results for commit 4cd3f97. ± Comparison against base commit acac76c. |
Test Results (shard 0)2 230 tests ±0 2 224 ✅ - 1 8m 18s ⏱️ -3s For more details on these failures, see this check. Results for commit 4cd3f97. ± Comparison against base commit acac76c. |
Test Results 47 files ± 0 47 suites ±0 25m 31s ⏱️ + 3m 8s For more details on these failures, see this check. Results for commit 4cd3f97. ± Comparison against base commit acac76c. |
Why self-update's continuous channel never rolled.
memex/Directory.Build.propswas a bare<Project>that didn't import the root, and MSBuild auto-imports only the nearestDirectory.Build.props. So everything undermemex/— the portal + migration images, i.e. exactly what the self-updater rolls — never got the root's CI versioning, security package overrides, orTreatWarningsAsErrors. The images were tagged the SDK default1.0.0instead of$(PlatformVersion)-ci.$(GITHUB_RUN_NUMBER), so the self-updater saw nothing "newer" (every tag was1.0.0).GetPathOfFileAbove). Verified: CI build now computes3.0.0-ci.<run>, release3.0.0.TreatWarningsAsErrorsformemex/(it had silently escaped the repo's warnings-as-errors gate — "that's why we have it" 🙂), surfacing 12 latent doc-comment issues, all fixed: 8 unresolvable/ambiguous crefs inMemex.Portal.Shared; 1 malformed-XML<summary>+ 3 cross-assembly crefs inDatabase.Migration.memex/builds clean under the gate now.Completes the self-update chain (with #116): the continuous channel will now publish monotonically-increasing
-ci.Nimages for installs to roll to.🤖 Generated with Claude Code