Repository navigation
RequirePrebuilt: first access parks with a named refusal — Roslyn never starts (#2193 §A completion) - #2209
Merged
Conversation
…er starts (#2193 §A) The adopt-only gate at the ONE seam every route into a compile passes through: the compile watcher's Pending handler. On a mesh that sets Modules:RequirePrebuilt, a type flipped to Pending without a usable build — first access, a release request, a self-heal, a framework-stale rebuild — is PARKED (deterministic) and settled at Error with one named reason: the type, the framework identity/architecture the assembly is missing for, the package whose bundle publishes it, and how to retry. Every instance page renders that reason through the compilation-error overlay instead of hanging; the park registry's attempt counter stays at zero — the observable proof no Roslyn pass started. The park carries the type's current source snapshot so the sources watcher cannot un-park it against a null baseline (a park/un-park ping-pong, caught by the pin). Flag off: unchanged. Pinned in RequirePrebuiltParkTest (valid config, no bundle → Error naming key/type/identity/package, parked, zero attempts); NodeTypeCompileParkTest stays green as the control. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Contributor
Contributor
Contributor
Contributor
Test Results (shard 2)3 352 tests +7 3 352 ✅ +7 8m 17s ⏱️ +17s Results for commit 90735c6. ± Comparison against base commit b7673a1. This pull request removes 90 and adds 97 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
Test Results (shard 1)1 763 tests - 6 1 763 ✅ - 6 9m 43s ⏱️ +46s Results for commit 90735c6. ± Comparison against base commit b7673a1. This pull request removes 97 and adds 91 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2198 (retargets to
mainwhen it merges). Completes MeshWeaver#2193 §A at the deepest seam.What changed
The compile watcher's Pending handler is the one point every route into Roslyn passes through — first access, a release request (which un-parks first, then lands here), a self-heal kick, a framework-stale rebuild. On a mesh that sets
Modules:RequirePrebuilt, a type flipped to Pending without a usable build is now:Errorwith one named reason: the type, the framework identity/architecture the assembly is missing for, the package whose bundle publishes it, and how to retry;Every instance page renders that reason through the existing compilation-error overlay instead of waiting on a compile that was never going to be allowed. The park carries the type's current source snapshot so the sources watcher cannot un-park it against a null baseline (the pin caught exactly that ping-pong). Flag off: byte-for-byte unchanged.
Contract pinned
RequirePrebuiltParkTest(Monolith, flag on): a VALID type with no adopted assembly →Errornaming the policy key, the type, the live identity and the package;IsParkedtrue with the same reason;GetCompileAttemptCount == 0.NodeTypeCompileParkTestgreen as the flag-off control (7/7). Graph builds Release-warnaserror.Rollout
Nothing changes until a deployment opts in; enable together with #2198's install-lane refusal. Refs #2193. Merge is yours, Roland.
🤖 Generated with Claude Code