Repository navigation
helm: render Modules__Required__5..7 (the engine guard's overlay entry reached no container) - #2512
Merged
Merged
Conversation
…ry reached no container The chart's named-key list stopped at index 4 while the overlays grew to 5 (MeshWeaver.AI — the required-modules guard entry added after the 2026-08-27 engine outage). The config-key coverage gate caught the key reaching NO container on Memex#129 — the fifth recurrence of the named-key omission class (#1925/#1778/#1780/#2203). Indices 5..7 render now, with headroom so the NEXT required module does not silently vanish. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QVbVvrHeU1gm8oq4PuMVjF
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Memex portal Helm chart ConfigMap template to ensure additional Modules__Required__* configuration keys (indices 5–7) are rendered into the container environment, preventing overlay-declared required modules from being silently dropped due to missing named keys in the template.
Changes:
- Add explicit ConfigMap entries (guarded by
hasKey) forModules__Required__5,Modules__Required__6, andModules__Required__7. - Add an in-template comment documenting the omission recurrence and the rationale for adding headroom.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memex#129's config-key coverage gate caught
Modules__Required__5(theMeshWeaver.AIguard entry the overlays declare since the 2026-08-27 engine outage) reaching NO container — the chart's named-key list stops at index 4. Fifth recurrence of the named-key omission class (#1925/#1778/#1780/#2203). Renders indices 5..7 (samehasKeypattern), with two spare so the next required module doesn't silently vanish. Template-only; no image change.🤖 Generated with Claude Code
https://claude.ai/code/session_01QVbVvrHeU1gm8oq4PuMVjF