Repository navigation
type-forwards.allow: retire the nine #2678 entries (stale now that the carve-out shipped) - #2688
Merged
Merged
Conversation
… so, on every open PR The views carve-out (#2678) has shipped, so its allow entries are now STALE: the gate compares against the merge base, which under the merge-ref checkout is always main's tip, so no open PR's diff moves those types any more and the file's own rule fires — 'an entry that outlives its change hides the next break'. Every open core PR (#2685, #2686, …) reddened on 'Public surface (binary compatibility)', and Consolidate folds that gate in, so every core merge was blocked. Verified: gate OK against origin/main with the block removed; 28 self-tests pass.
Contributor
There was a problem hiding this comment.
Pull request overview
Retires stale type-forwards.allow entries that were only needed during the #2678 Graph Views carve-out window, unblocking the Public surface (binary compatibility) ratchet now that the move has already landed on main.
Changes:
- Removes the nine #2678
MeshWeaver.Graph:*LayoutAreasallowlist entries so the stale-entry ratchet stops failing on unrelated PRs. - Deletes the now-obsolete explanatory comment block tied to those allow entries.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This was referenced Aug 30, 2026
rbuergi
added a commit
that referenced
this pull request
Aug 30, 2026
merged (#2783) `scripts/type-forwards.allow` still lists MeshWeaver.Fixture:MeshWeaver.Fixture.ObservableAwait but #2771 has merged, so that move is IN main. The gate compares against the MERGE BASE, so relative to any branch cut after #2771 nothing of that name moves — and the entry is reported as STALE: STALE ALLOW ENTRY: scripts/type-forwards.allow lists `MeshWeaver.Fixture:MeshWeaver.Fixture.ObservableAwait`, but nothing of that name moved in this diff 🚨 That reddens EVERY subsequent PR, not one. Measured: both currently open PRs fail `Public surface (binary compatibility)` on it — #2782 (a test guard plus an allow file) and #2781 (a documentation-only Homebrew change). Neither can reach a public type; both are blocked by main. This is the failure mode the allow file's own rule names and that #2678 -> #2688 already paid for once: an allow entry goes stale FLEET-WIDE the instant its move merges, so it must be deleted in the VERY NEXT change. It was flagged on #2771 before that merge and landed with it anyway, which is exactly how the previous seven stale entries accumulated. The file now carries no live entries — header only, which is the correct state: nothing is currently exempt. Verified: scripts/check-type-forwards.py --self-test -> All 28 self-tests passed scripts/check-type-forwards.py --base <merge-base> -> OK, no unguarded public-type move Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The views carve-out (#2678) shipped, so its nine allow entries are STALE and the ratchet fails
Public surface (binary compatibility)on every open core PR — andConsolidate test resultsfolds that gate in, so every core merge is blocked (#2685, #2686 observed).Under the merge-ref checkout the gate's base is always main's tip, so once a guarded move lands the entries must go in the very next change. This is that change: removes the block, nothing else. Gate OK against
origin/main; 28 self-tests pass.🤖 Generated with Claude Code