Skip to content

docs: register governed-action-preflight and action-page-controls-and-queries; skills carry the approval-operating lessons - #5787

Merged
meshweaver-cloud[bot] merged 4 commits into
mainfrom
docs/digest-0925-26-rules
Sep 27, 2026
Merged

meshweaver-cloud[bot] merged 4 commits into
mainfrom
docs/digest-0925-26-rules

Conversation

@rbuergi

@rbuergi rbuergi commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #5786, which was already in the merge queue. It is stacked on that branch, so until #5786 merges the diff also shows #5786's commits. Only the last commit is new.

  • PolicyNotProse: two proposed rows, from maintainer rules relayed today.
    • governed-action-preflight: every step of a governed action runs as system, and rights and scale are pre-flighted at PLAN time, so an action refuses at park and never partway through a destructive run. The evidence is a DeleteSpace that failed at step 9, on 31,138 per-node delete validations against a 25 s bound, after its grant and GitSync were already removed.
    • action-page-controls-and-queries: an activity or action page is built from controls (cards, grids, query controls with "show matching nodes"), sets are mesh queries (top-level + scope:subtree), and the summary goes last.
    • Both rows are proposed because their implementation in MeshWeaver.Plugins is in flight. Plugins Progress-streaming tests gate the script on an attached subscriber (#2421 was a subscribe-late race, not batching) #2424 documents them in Hosting/AksOperationsViaActions and Hosting/DeleteSpaceAction.
  • /deployment: the pre-flight rule. The maintainer self-approval now follows the operating lessons Plugins feat(slideshow): SlideShowControl gains frames mode — the whole deck, pre-rendered #2422 recorded: wait for the park; approvedPlan is recomputed from actionPlan because the node does not store it; the digest binds commands, not the values file or operator environment; and approvable is not yet runnable.
  • /gui: the action-page rule.

MeshWeaver.Documentation.Test passes locally (649/649).

Pairs-with: none — documentation and skills only.

🤖 Generated with Claude Code

rbuergi and others added 3 commits September 27, 2026 08:23
…ions into pages and skills

- TheBakeGateOnlyStallsARoll: the post-fix startup budget (60 on memex + memex-cloud) and an
  incident history table.
- PlanningADatabaseMigration: the V58 unblock needed a vault capture before the Reconcile; Related.
- DeploymentAKS: link the migration process; the 600 s budget; Recycle/DeleteSpace rows; approval
  bound to the plan; the Key Vault key -> Restart finding; the --subscription trap.
- IssueTaxonomy: how an issue reaches triage (org webhook, periodic sweep, triage scope).
- SelfUpdateAnnouncementKey: where the rollout stands.
- Skills: /deployment (governed actions, probes, migrations, subscription trap; control-instance
  host corrected), /ci, /testing, /gui, /release, /pullrequest (working beside other sessions),
  /worktree.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… a roll gate in the probe summary; the 600 s budget needs #5749 AND #5754

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…-queries (proposed); skills carry them and the approval-operating lessons

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 27, 2026 06:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical deployment documentation issues and a moderate approval-procedure issue remain unresolved.

Review effort: Lite
Findings: 2 High severity · 1 Low severity

Open (3)
What changed in this PR

Updates architecture documentation and operational skills with governed-action, deployment, migration, testing, GUI, CI, and collaboration guidance.

Changes:

  • Registers two proposed governance policies.
  • Documents deployment, migration, rollout, triage, and incident lessons.
  • Updates skills for approvals, testing, releases, GUI composition, CI, and worktrees.
File Description
src/​MeshWeaver.Documentation/​Data/​Architecture/​TheBakeGateOnlyStallsARoll.md Adds startup-budget guidance and incident history.
src/​MeshWeaver.Documentation/​Data/​Architecture/​SelfUpdateAnnouncementKey.md Records rollout status.
src/​MeshWeaver.Documentation/​Data/​Architecture/​PolicyNotProse.md Registers two proposed policies.
src/​MeshWeaver.Documentation/​Data/​Architecture/​PlanningADatabaseMigration.md Documents Key Vault capture prerequisites.
src/​MeshWeaver.Documentation/​Data/​Architecture/​IssueTaxonomy.md Documents issue-triage routes.
src/​MeshWeaver.Documentation/​Data/​Architecture/​DeploymentAKS.md Adds AKS subscription and governed-action guidance.
.claude/​skills/​worktree/​SKILL.md Adds worktree collision safeguards.
.claude/​skills/​testing/​SKILL.md Documents in-mesh test execution.
.claude/​skills/​release/​SKILL.md Clarifies source-sync and seal behavior.
.claude/​skills/​pullrequest/​SKILL.md Adds multi-session workflow guidance.
.claude/​skills/​gui/​SKILL.md Adds action-page composition rules.
.claude/​skills/​deployment/​SKILL.md Adds plan-bound approval guidance.
.claude/​skills/​ci/​SKILL.md Adds migration and probe invariants.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .claude/skills/deployment/SKILL.md Outdated
Comment on lines +156 to +160
🚨 **Pass `--subscription 7ecc5974-5319-4596-ad2b-3470f6b7f85c` on EVERY `az` call** — written
`<subscription>` in every example below. The default
subscription may be "PartnerRe Memex", which holds another cluster with the SAME name
(`<aks-cluster>`); without the flag you read the wrong system and nothing says so.
`az role assignment delete --ids …` needs it too, or it fails with `InvalidAuthenticationTokenTenant`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 50c477b. The skill (and DeploymentAKS) now use the placeholder and point to the private Memex repo (docs/aks-ops.md) for the id. The other tenant's name is gone; the text says only that the default subscription may belong to another tenant's installation. Older public files that already carry the id (delete-user, new-repo and release skills, operator tests) are outside this diff.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(re-posted 2026-10-11; originally by Copilot on 2026-09-27)

This committed skill also exposes the deployment's real Azure subscription ID and tenant name (ClientA Memex) in a public skill. Deployment identities must remain private; use the existing <subscription> placeholder instead of copying the value from Memex.

Comment on lines +730 to +737
🚨 **Always pass `--subscription 7ecc5974-5319-4596-ad2b-3470f6b7f85c` to every `az` call on this
page** (`<subscription>` in the examples). The
signed-in account's DEFAULT subscription may be "PartnerRe Memex", which holds ANOTHER cluster with
the same name in a resource group of the same name (`<aks-cluster>` in `<aks-resource-group>`). Without the flag, `az aks command invoke`
answers from that cluster, with different nodes and a different migration history, and nothing in
the output says so. The same applies to `az role assignment delete --ids …`: it does not take the
subscription from the id, uses the default account's tenant, and fails with
`InvalidAuthenticationTokenTenant`. Pass `--subscription` there too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 50c477b. The onboarding example now reads az identity federated-credential create --subscription …, so every concrete az command on the page carries the flag. The warning's own mention of role assignment delete --ids already says to pass --subscription.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(re-posted 2026-10-11; originally by Copilot on 2026-09-27)

This new blanket instruction is not true for every az command on the page: the onboarding alternative at line 426 still shows az identity federated-credential create without --subscription. An operator following that example can resolve the same-named resource in the default ClientA subscription, exactly the ambiguity this addition is meant to prevent. Add the subscription to every concrete command (including that onboarding example), or narrow this warning and link to the corrected command.

This issue also appears on line 730 of the same file.


## Incident history

The outage of the control instance, 2026-09-25/26, as three failures and the change that closed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 50c477b. It now reads: "The table lists the control instance's outage of 2026-09-25/26 as three failures, each with the change that closed it."

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Test Results (shard 3)

444 tests   - 16   444 ✅  - 16   1m 10s ⏱️ +32s
  2 suites  -  1     0 💤 ± 0 
  2 files    -  1     0 ❌ ± 0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Test Results (shard 1)

555 tests   - 1 135   555 ✅  - 1 135   1m 23s ⏱️ - 2m 51s
  1 suites  -     1     0 💤 ±    0 
  1 files    -     1     0 ❌ ±    0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Test Results (shard 0)

  1 files  ±0    1 suites  ±0   2m 20s ⏱️ -50s
348 tests ±0  348 ✅ ±0  0 💤 ±0  0 ❌ ±0 
352 runs  ±0  352 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

♻️ This comment has been updated with latest results.

…scription> placeholder, id kept in Memex; federated-credential example scoped; incident-history intro is a sentence

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test Results (shard 4)

    2 files   -   1      2 suites   - 1   6m 34s ⏱️ +12s
2 781 tests +625  2 781 ✅ +625  0 💤 ±0  0 ❌ ±0 
2 782 runs  +625  2 782 ✅ +625  0 💤 ±0  0 ❌ ±0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results (shard 2)

1 670 tests  +908   1 670 ✅ +1 099   9m 54s ⏱️ + 2m 46s
    2 suites  -   1       0 💤  -   191 
    2 files    -   1       0 ❌ ±    0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results (shard 5)

    4 files   -   1      4 suites   - 1   14m 27s ⏱️ +41s
3 591 tests  - 662  3 591 ✅  - 660  0 💤  - 2  0 ❌ ±0 
3 595 runs   - 662  3 595 ✅  - 660  0 💤  - 2  0 ❌ ±0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   12 files   -   5     12 suites   - 5   35m 50s ⏱️ +29s
9 389 tests  - 280  9 389 ✅  - 87  0 💤  - 193  0 ❌ ±0 
9 398 runs   - 280  9 398 ✅  - 87  0 💤  - 193  0 ❌ ±0 

Results for commit 50c477b. ± Comparison against base commit b6cdaac.

@meshweaver-cloud
meshweaver-cloud Bot added this pull request to the merge queue Sep 27, 2026
Merged via the queue into main with commit e18018d Sep 27, 2026
49 checks passed
@rbuergi
rbuergi deleted the docs/digest-0925-26-rules branch October 10, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants