Repository navigation
fix(build-hosts): host pods select workload=ci-build, the label the CI node pools carry - #7159
Merged
Merged
Conversation
…he CI node pools carry The chart defaulted to workload=cibuild, a label no node carries: the CI pools (cibuildv6, cidind) are labelled workload=ci-build (the ARC runners select the same), so every build-host pod would have stayed Pending. The chart test now pins the real label; with the old one it fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow selector correction is covered by the updated regression assertion and does not enable workloads.
No open issues 🎉
What changed in this PR
Corrects the build-host Helm default to match the CI node pools’ label, preventing unschedulable pods when build hosts are enabled.
Changes:
- Changes the node selector from
workload: cibuildtoworkload: ci-build. - Updates the regression assertion and diagnostic to require the corrected label.
- Leaves build hosts disabled by default and tolerations unchanged.
| File | Description |
|---|---|
deploy/helm/values.yaml |
Corrects the build-host node selector. |
deploy/aks/scripts/test-build-hosts.sh |
Updates the selector assertion, diagnostic, and explanatory comment. |
Review effort: Balanced
Contributor
Test Results 31 files ±0 31 suites ±0 1h 8m 56s ⏱️ +54s Results for commit fb26a17. ± Comparison against base commit 19ac9a0. This pull request removes 44 and adds 18 tests. Note that renamed tests count towards both. |
This was referenced Oct 25, 2026
rbuergi
added a commit
that referenced
this pull request
Oct 25, 2026
Every conflict resolved so the deletion wins: the chart files main changed (#7143, #7159, #7184, #7170, #7119; all ported to MeshWeaver.Deploy by Deploy#4), the chart-reading guards main moved onto RepoPaths (#7111), and the Memex.Portal.Shared files main moved to MeshWeaver.Plugins (#7125). Also deleted: the build-host chart files main added after this branch was cut (frozen, in Deploy now) and memex-local.yml (#7119), whose Linux gate is Deploy's homebrew.yml linux job. Kept from main: instances.json's re-measured MeshWeaver.Deploy row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while preparing the build hosts' enable. The chart's default
buildHosts.nodeSelectorwasworkload: cibuild, and no node carries that label. The CI node pools (cibuildv6,cidind) are labelledworkload: ci-build, which is also what the ARC runners select (deployments/aks/ci-runners/arc-runner-scale-set-values.yamlin the estate repo). Every build-host pod would therefore have stayed Pending. The tolerations (ci=build, spot) already match.deploy/helm/values.yaml: the default is nowworkload: ci-build.deploy/aks/scripts/test-build-hosts.shpins the real label. It passes, and with the old label it fails (exit 1).Nothing runs build hosts yet (
buildHosts.enabled: falseeverywhere), so this changes no running workload.🤖 Generated with Claude Code