Repository navigation
chore(platform): core drops memex/ and the dead Roslynator pins (delete half) - #7297
Conversation
…te half) memex/MeshModulesPublish.targets and memex/aspire/Memex.Portal.ServiceDefaults are MeshWeaver.Plugins' now (Plugins#4333); memex/Directory.Build.props served only them. Gone with them: the slnx entries, MeshWeaver.Hosting.Test's ServiceDefaults reference and AnArbitraryUrlFetcherGivingUpIsAWarningTest (moved to Memex.Portal.Shared.Test), .aspire/settings.json and two .gitignore lines that pointed at memex/aspire paths core no longer has, and 'memex' from every source guard's scanned roots. Roslynator: five PackageVersion pins no core project restores, whose only use was a PackageReference Update= block in MeshWeaver.Layout.csproj that matched no Include. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…les-publish-targets
Test Results 25 files ±0 25 suites ±0 55m 50s ⏱️ - 1m 4s Results for commit 8112cb8. ± Comparison against base commit 4cc5c17. This pull request removes 63 and adds 22 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Review re-requested on the maintainer's instruction (Copilot had refused for requester quota, review 5666576141); |
There was a problem hiding this comment.
🔵 Needs a closer look
Plugins #4333 returned 404, so human review must confirm preservation of the relocated implementation and host/build wiring, and that the addition half has merged before this deletion lands.
No open issues 🎉
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
The required companion PR, Systemorph/MeshWeaver.Plugins#4333, returned 404, preventing verification that the replacement files, updated host imports, and relocated tests are on the default branch before these deletions land.
No open issues 🎉
Review effort: Balanced
…oy is declarable (#7514) #7297 deleted memex/aspire/Memex.Portal.ServiceDefaults/Memex.Portal.ServiceDefaults.csproj. The cross-repo pair gate's trigger is the surface report, which scans public types under src/ only, so it reported nothing for that file — and MeshWeaver.Deploy, whose chart guards check core out and ProjectReference its paths, went red (MSB9008 + CS0246) on every pull request until it adapted. Even a declaring author could not have paired it: Deploy was not in the register, so `Pairs-with: Systemorph/MeshWeaver.Deploy#N` was refused as "not a sibling repository". - check-cross-repo-pair.py lists the .csproj files the diff deletes or renames (merge base -> HEAD, rename-aware, -z), with its own control arm (a base tree under 20 project files fails), and either list being non-empty asks for the Pairs-with declaration. - The register gains `pair-only-repos` (MeshWeaver.Deploy): declarable counterparts that the shared-rules gate does not read. The job's fleet-reader mint and probe cover it. - Self-tests replay #7297's own deleted file (it passed before), a rename, a Deploy counterpart (refused before), the missing/starved report, and the listing over a real throwaway repo. Refs #7415 Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Core stops carrying the
memex/folder. Everything in it belonged to the portal hosts, which live in MeshWeaver.Plugins. This is the DELETE half. It stays a draft until Systemorph/MeshWeaver.Plugins#4333, the addition half, has merged, because core CD publishes the hosts from Pluginsmainat its head.Deleted
memex/MeshModulesPublish.targets, which Plugins now carries assrc/MeshModulesPublish.targets.memex/aspire/Memex.Portal.ServiceDefaults, which Plugins now carries assrc/Memex.Portal.ServiceDefaults.memex/Directory.Build.props, which only served those two.MeshWeaver.slnxfolder entries formemex/.MeshWeaver.Hosting.Test's reference to ServiceDefaults, andAnArbitraryUrlFetcherGivingUpIsAWarningTest, which moved to Plugins'Memex.Portal.Shared.Test..aspire/settings.jsonand two.gitignorelines. All three pointed atmemex/aspire/paths core no longer has, including the AppHost.memexfrom the scanned roots of 20 source guards.NoLiteralNulInSourceGuardrefused the now-empty root, which is its job; the other 19 skipped it silently.PackageVersionpins no core project restores (measured from everyobj/project.assets.jsonafter a full solution restore). Their only use was aPackageReference Update=block inMeshWeaver.Layout.csprojthat matched noInclude. Every satellite that runs Roslynator pins it in its own list, and Plugins does not use it.Kept: the reader side of the module layout (
ImageModuleSeed,PlatformShippedAssemblies,MeshBuilder.ResolveModulePath). Their comments now name the Plugins paths.Docs:
CoreCarriesNoGuiTechnologymarksmemex/as moved.CarvingProjectsOutOfCorerecords the second package pass.Verified locally, Release with
-warnaserror:MeshWeaver.slnxrestores clean.MeshWeaver.Documentation.Testpasses 878 of 878.InlineSvgEmissionBackplateGuardandPackableProjectReadmeTestpass 13 of 13.GrainActivationSiteRatchetGuardpasses 3 of 3.Pairs-with: Systemorph/MeshWeaver.Plugins#4333
Satellite-pins: Roslynator.Analyzers — checked MeshWeaver.Plugins main: no PackageReference (Include or Update) to it in any csproj, props or targets file; no core project restores it either, so the pin governed nothing.
Satellite-pins: Roslynator.CodeAnalysis.Analyzers — checked MeshWeaver.Plugins main: no PackageReference (Include or Update) to it in any csproj, props or targets file; no core project restores it either, so the pin governed nothing.
Satellite-pins: Roslynator.CodeFixes — checked MeshWeaver.Plugins main: no PackageReference (Include or Update) to it in any csproj, props or targets file; no core project restores it either, so the pin governed nothing.
Satellite-pins: Roslynator.Formatting.Analyzers — checked MeshWeaver.Plugins main: no PackageReference (Include or Update) to it in any csproj, props or targets file; no core project restores it either, so the pin governed nothing.
Satellite-pins: Roslynator.Refactorings — checked MeshWeaver.Plugins main: no PackageReference (Include or Update) to it in any csproj, props or targets file; no core project restores it either, so the pin governed nothing.
🤖 Generated with Claude Code