Skip to content

Space delete-cleanup wait sat below the delete operation's own 30s contract #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuergi merged 1 commit into from
Aug 7, 2026
Merged

Space delete-cleanup wait sat below the delete operation's own 30s contract #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/MeshWeaver.NodeOperations.Test/SpaceMenuAndAccessTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,12 @@ public async Task Space_HasStandardCreatableTypes()
typeNames.Should().Contain("Thread", "Thread should be creatable under Space");
typeNames.Should().Contain("Agent", "Agent should be creatable under Space");

await NodeFactory.DeleteNode(spaceId).Should().Emit();
// The recursive delete fans out a DeleteNodeRequest per descendant (here: the creator
// _Access grant), each ACTIVATING that leaf's per-node hub — 5-45s cold start on a loaded
// CI shard (HandleDeleteNodeRequest). The operation's own ceiling is
// MeshOperationOptions.Timeout (30s); waiting only the 10s assertion default sat BELOW the
// operation's contract and was the shard-5 red on otherwise-green runs.
await NodeFactory.DeleteNode(spaceId).Should().Within(30.Seconds()).Emit();
Comment on lines +125 to +130
}

[Fact(Timeout = 60000)]
Expand Down Expand Up @@ -153,6 +158,8 @@ await NodeFactory.CreateNode(
children.Should().Contain(c => c.NodeType == "Markdown" && c.Path == $"{spaceId}/Overview",
"Overview markdown page should exist as child");

await NodeFactory.DeleteNode(spaceId).Should().Emit();
// Same wait-to-the-operation's-contract as above — this delete additionally fans out to
// the Overview child's hub, so two cold per-node activations sit inside the wait.
await NodeFactory.DeleteNode(spaceId).Should().Within(30.Seconds()).Emit();
}
}
Loading