Repository navigation
revert: remove harbor as a harness - #229
Merged
Merged
Conversation
Perry2004
commented
Jun 14, 2026
Perry2004
commented
Collaborator
- Remove harbor as a harness.
- It will, in the future, be integrated as a test runner as described in FEAT: integrate ClawBench into Harbor framework #223.
- Remove harbor as a harness. - It will in future be integrated as a test runner as described in #223
reacher-z
added a commit
that referenced
this pull request
Jun 27, 2026
Resolve conflicts after main reverted harbor-as-a-harness (#229) and added the separate harbor adaptor (#232), plus the remote-browser CDP refactor (#235). Resolution: - pyproject.toml: keep all harbor entry points — main's clawbench-harbor-adapt alongside the feature's clawbench-export-harbor / clawbench-harbor-parity. - runtime/harnesses/harbor/{harbor_driver.py,run-harbor.sh}: restore (main deleted, branch modified) to preserve the harbor harness the feature drives; re-add the harbor block to harnesses.yaml and "harbor" to EXPECTED_HARNESSES. - Restore Dockerfile.harbor / setup-harbor.sh / usage-emitter.py (deleted by main) so the registered harbor harness stays complete. - Adapt harbor to main's shared CDP API: read CLAWBENCH_BROWSER_CDP_URL instead of the hard-coded http://127.0.0.1:9222 (harbor_driver.py CDP_URL + docstring, run-harbor.sh readiness probe) to satisfy test_harnesses_use_shared_browser_cdp_env. - Adopt main's evolution everywhere else (runtime-server rename, browser_runtime providers, eval/harbor_adapter, runtime/harbor, base entrypoint) unchanged. ruff check + format, pyright (0 errors), and pytest (161 passed) all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.